Remove last extension dependencies from content.

Remove last extension dependencies from content.
- UserScript reference from BufferedResourceHandler.
- ExtensionInfoMap references from RenderMessageFilter and WorkerProcessHost
and ResourceContext.

BUG=76697
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88388

[Matt Perry, 2011-06-07 22:29:42]

Waiting for http://codereview.chromium.org/7125006/ before checking in.

[jam, 2011-06-07 23:17:52]

http://codereview.chromium.org/7135003/diff/4001/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/7135003/diff/4001/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:386:
io_data->GetExtensionInfoMap()->extensions().GetByID(url.host());
nit: spacing

http://codereview.chromium.org/7135003/diff/4001/content/browser/content_brow...
File content/browser/content_browser_client.h (right):

http://codereview.chromium.org/7135003/diff/4001/content/browser/content_brow...
content/browser/content_browser_client.h:149: // Returns a title string to use
in the task manager for a process host with
I think this is only called on the IO thread right?  if so we should say that.

should we also make it specific to workers?  i.e. GetWorkerProcessTitle?

http://codereview.chromium.org/7135003/diff/4001/content/browser/content_brow...
content/browser/content_browser_client.h:155: // Otherwise, the content layer
decides.
ditto about IO thread

http://codereview.chromium.org/7135003/diff/4001/content/browser/renderer_hos...
File content/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/7135003/diff/4001/content/browser/renderer_hos...
content/browser/renderer_host/buffered_resource_handler.cc:380: if
(content::GetContentClient()->browser()->ShouldForceDownloadResource(
i'm curious what you think about putting this callback in
ResourceDispatcherHostObserver since it's related to RDH?

[Matt Perry, 2011-06-07 23:58:09]

http://codereview.chromium.org/7135003/diff/4001/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/7135003/diff/4001/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:386:
io_data->GetExtensionInfoMap()->extensions().GetByID(url.host());
On 2011/06/07 23:17:53, John Abd-El-Malek wrote:
> nit: spacing

Done.

http://codereview.chromium.org/7135003/diff/4001/content/browser/content_brow...
File content/browser/content_browser_client.h (right):

http://codereview.chromium.org/7135003/diff/4001/content/browser/content_brow...
content/browser/content_browser_client.h:149: // Returns a title string to use
in the task manager for a process host with
On 2011/06/07 23:17:53, John Abd-El-Malek wrote:
> I think this is only called on the IO thread right?  if so we should say that.
> 
> should we also make it specific to workers?  i.e. GetWorkerProcessTitle?

Done.

http://codereview.chromium.org/7135003/diff/4001/content/browser/content_brow...
content/browser/content_browser_client.h:155: // Otherwise, the content layer
decides.
On 2011/06/07 23:17:53, John Abd-El-Malek wrote:
> ditto about IO thread

Done.

http://codereview.chromium.org/7135003/diff/4001/content/browser/renderer_hos...
File content/browser/renderer_host/buffered_resource_handler.cc (right):

http://codereview.chromium.org/7135003/diff/4001/content/browser/renderer_hos...
content/browser/renderer_host/buffered_resource_handler.cc:380: if
(content::GetContentClient()->browser()->ShouldForceDownloadResource(
On 2011/06/07 23:17:53, John Abd-El-Malek wrote:
> i'm curious what you think about putting this callback in
> ResourceDispatcherHostObserver since it's related to RDH?

Done.

[jam, 2011-06-08 00:18:17]

http://codereview.chromium.org/7135003/diff/4002/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/7135003/diff/4002/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:463: const GURL& url, const
content::ResourceContext& context) {
nit: add DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

http://codereview.chromium.org/7135003/diff/4002/content/browser/renderer_hos...
File content/browser/renderer_host/render_message_filter.cc (right):

http://codereview.chromium.org/7135003/diff/4002/content/browser/renderer_hos...
content/browser/renderer_host/render_message_filter.cc:385: // If the opener is
trying to create a background window but doesn't have
I just realized, BackgroundContents is a chrome concept.  Can you move this
whole block over to chrome?  i.e. ContentBrowserClient::CanCreateWindow

http://codereview.chromium.org/7135003/diff/4002/content/browser/renderer_hos...
File content/browser/renderer_host/resource_dispatcher_host.h (right):

http://codereview.chromium.org/7135003/diff/4002/content/browser/renderer_hos...
content/browser/renderer_host/resource_dispatcher_host.h:239: bool
ShouldForceDownloadResource(
how about just exposing delegate_?  then we don't need to proxy through RDH. 
we'll have more places that'll want this.

http://codereview.chromium.org/7135003/diff/4002/content/browser/worker_host/...
File content/browser/worker_host/worker_process_host.cc (right):

http://codereview.chromium.org/7135003/diff/4002/content/browser/worker_host/...
content/browser/worker_host/worker_process_host.cc:459: // Allow the content
client first crack at special casing the title.
nit: content client -> embedder

[jam, 2011-06-08 00:21:46]

also can you remove the headers from content\browser\DEPS

[Matt Perry, 2011-06-08 00:33:37]

http://codereview.chromium.org/7135003/diff/4002/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/7135003/diff/4002/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:463: const GURL& url, const
content::ResourceContext& context) {
On 2011/06/08 00:18:17, John Abd-El-Malek wrote:
> nit: add DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

Done.

http://codereview.chromium.org/7135003/diff/4002/content/browser/renderer_hos...
File content/browser/renderer_host/render_message_filter.cc (right):

http://codereview.chromium.org/7135003/diff/4002/content/browser/renderer_hos...
content/browser/renderer_host/render_message_filter.cc:385: // If the opener is
trying to create a background window but doesn't have
On 2011/06/08 00:18:17, John Abd-El-Malek wrote:
> I just realized, BackgroundContents is a chrome concept.  Can you move this
> whole block over to chrome?  i.e. ContentBrowserClient::CanCreateWindow

Done.

http://codereview.chromium.org/7135003/diff/4002/content/browser/renderer_hos...
File content/browser/renderer_host/resource_dispatcher_host.h (right):

http://codereview.chromium.org/7135003/diff/4002/content/browser/renderer_hos...
content/browser/renderer_host/resource_dispatcher_host.h:239: bool
ShouldForceDownloadResource(
On 2011/06/08 00:18:17, John Abd-El-Malek wrote:
> how about just exposing delegate_?  then we don't need to proxy through RDH. 
> we'll have more places that'll want this.

Done.

http://codereview.chromium.org/7135003/diff/4002/content/browser/worker_host/...
File content/browser/worker_host/worker_process_host.cc (right):

http://codereview.chromium.org/7135003/diff/4002/content/browser/worker_host/...
content/browser/worker_host/worker_process_host.cc:459: // Allow the content
client first crack at special casing the title.
On 2011/06/08 00:18:17, John Abd-El-Malek wrote:
> nit: content client -> embedder

Done.

[jam, 2011-06-08 00:46:26]

lgtm, thanks for doing this