Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: src/arm/code-stubs-arm.cc

Issue 7134106: Update an outdated comment in the CEntryStub on ARM. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Small edits. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3385 matching lines...) Expand 10 before | Expand all | Expand 10 after
3396 __ b(eq, &alignment_as_expected); 3396 __ b(eq, &alignment_as_expected);
3397 // Don't use Check here, as it will call Runtime_Abort re-entering here. 3397 // Don't use Check here, as it will call Runtime_Abort re-entering here.
3398 __ stop("Unexpected alignment"); 3398 __ stop("Unexpected alignment");
3399 __ bind(&alignment_as_expected); 3399 __ bind(&alignment_as_expected);
3400 } 3400 }
3401 } 3401 }
3402 #endif 3402 #endif
3403 3403
3404 __ mov(r2, Operand(ExternalReference::isolate_address())); 3404 __ mov(r2, Operand(ExternalReference::isolate_address()));
3405 3405
3406 3406 // To let the GC traverse the return address of the exit frames, we need to
3407 // TODO(1242173): To let the GC traverse the return address of the exit 3407 // know where the return address is. The CEntryStub is unmovable, so
3408 // frames, we need to know where the return address is. Right now, 3408 // we can store the address on the stack to be able to find it again and
3409 // we store it on the stack to be able to find it again, but we never 3409 // we never have to restore it, because it will not change.
3410 // restore from it in case of changes, which makes it impossible to
3411 // support moving the C entry code stub. This should be fixed, but currently
3412 // this is OK because the CEntryStub gets generated so early in the V8 boot
3413 // sequence that it is not moving ever.
3414
3415 // Compute the return address in lr to return to after the jump below. Pc is 3410 // Compute the return address in lr to return to after the jump below. Pc is
3416 // already at '+ 8' from the current instruction but return is after three 3411 // already at '+ 8' from the current instruction but return is after three
3417 // instructions so add another 4 to pc to get the return address. 3412 // instructions so add another 4 to pc to get the return address.
3418 masm->add(lr, pc, Operand(4)); 3413 masm->add(lr, pc, Operand(4));
3419 __ str(lr, MemOperand(sp, 0)); 3414 __ str(lr, MemOperand(sp, 0));
3420 masm->Jump(r5); 3415 masm->Jump(r5);
3421 3416
3422 if (always_allocate) { 3417 if (always_allocate) {
3423 // It's okay to clobber r2 and r3 here. Don't mess with r0 and r1 3418 // It's okay to clobber r2 and r3 here. Don't mess with r0 and r1
3424 // though (contain the result). 3419 // though (contain the result).
(...skipping 2977 matching lines...) Expand 10 before | Expand all | Expand 10 after
6402 __ mov(result, Operand(0)); 6397 __ mov(result, Operand(0));
6403 __ Ret(); 6398 __ Ret();
6404 } 6399 }
6405 6400
6406 6401
6407 #undef __ 6402 #undef __
6408 6403
6409 } } // namespace v8::internal 6404 } } // namespace v8::internal
6410 6405
6411 #endif // V8_TARGET_ARCH_ARM 6406 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698