Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 7134085: Make focus-existing-tab-on-open multi-profile-aware. (Closed)

Created:
9 years, 6 months ago by Miranda Callahan
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make focus-existing-tab-on-open multi-profile-aware. BUG=82696 TEST=see bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89013

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : Make focus-existing-tab-on-open multi-profile aware. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/tabs/tab_finder.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Miranda Callahan
jianli, I see you've done work in this area, and Peter for OWNERship.
9 years, 6 months ago (2011-06-12 16:29:37 UTC) #1
jianli
http://codereview.chromium.org/7134085/diff/4003/chrome/browser/tabs/tab_finder.cc File chrome/browser/tabs/tab_finder.cc (right): http://codereview.chromium.org/7134085/diff/4003/chrome/browser/tabs/tab_finder.cc#newcode101 chrome/browser/tabs/tab_finder.cc:101: if (!(*i)->profile()->IsOffTheRecord()) { I think it will be simpler ...
9 years, 6 months ago (2011-06-13 18:55:39 UTC) #2
Miranda Callahan
On 2011/06/13 18:55:39, jianli wrote: > http://codereview.chromium.org/7134085/diff/4003/chrome/browser/tabs/tab_finder.cc > File chrome/browser/tabs/tab_finder.cc (right): > > http://codereview.chromium.org/7134085/diff/4003/chrome/browser/tabs/tab_finder.cc#newcode101 > ...
9 years, 6 months ago (2011-06-13 19:25:21 UTC) #3
jianli
LGTM. You still need owner's approval on this patch.
9 years, 6 months ago (2011-06-13 19:42:36 UTC) #4
Miranda Callahan
On 2011/06/13 19:42:36, jianli wrote: > LGTM. > > You still need owner's approval on ...
9 years, 6 months ago (2011-06-14 12:27:54 UTC) #5
Miranda Callahan
9 years, 6 months ago (2011-06-14 12:28:13 UTC) #6
sky
LGTM
9 years, 6 months ago (2011-06-14 15:30:16 UTC) #7
commit-bot: I haz the power
9 years, 6 months ago (2011-06-14 16:45:38 UTC) #8
Change committed as 89013

Powered by Google App Engine
This is Rietveld 408576698