Issue 7134056: Disabled a bunch of ntp, translate, prefs, cookies and themes tests. Logged bugs and assigned own...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7134056: Disabled a bunch of ntp, translate, prefs, cookies and themes tests. Logged bugs and assigned own... (Closed)

Created:
9 years, 6 months ago by anantha

Modified:
9 years, 6 months ago

Reviewers:
kkania, Nirnimesh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/test/

Visibility:
Public.

Description

Disabled a bunch of ntp, translate, prefs, cookies and themes tests. Logged bugs and assigned owners to investigate. bug#s: 85601, 85600, 85598, 85597, 85596 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88593

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	functional/PYAUTO_TESTS	View	1 2 3	5 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kkania

LGTM after fix http://codereview.chromium.org/7134056/diff/4/functional/PYAUTO_TESTS File functional/PYAUTO_TESTS (right): http://codereview.chromium.org/7134056/diff/4/functional/PYAUTO_TESTS#newcode98 functional/PYAUTO_TESTS:98: 'themes', remove whitespace

9 years, 6 months ago (2011-06-09 21:27:03 UTC) #3

kkania

http://codereview.chromium.org/7134056/diff/4/functional/PYAUTO_TESTS File functional/PYAUTO_TESTS (right): http://codereview.chromium.org/7134056/diff/4/functional/PYAUTO_TESTS#newcode268 functional/PYAUTO_TESTS:268: '-translate.TranslateTest.testAlwaysTranslateInIncognito and you forgot ', here

9 years, 6 months ago (2011-06-09 21:27:33 UTC) #4

Nirnimesh

9 years, 6 months ago (2011-06-09 21:27:40 UTC) #5

LGTM

http://codereview.chromium.org/7134056/diff/4/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/7134056/diff/4/functional/PYAUTO_TESTS#newcode102
functional/PYAUTO_TESTS:102: # crbug.com/85597
All these tests are fine on chromium bots. Looks like last night's official
build was especially bad. These will need to be re-enabled when a new build
comes.

Expand Messages | Collapse Messages