Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 7134051: Merge 88396 - 2011-06-08 Sailesh Agrawal <sail@chromium.org> (Closed)

Created:
9 years, 6 months ago by Nico
Modified:
9 years, 6 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 88396 - 2011-06-08 Sailesh Agrawal <sail@chromium.org>; Reviewed by Mihai Parparita. Chromium Mac: Enable overlay scrollbars https://bugs.webkit.org/show_bug.cgi?id=59756 Enable WTF_USE_WK_SCROLLBAR_PAINTER for Chromium Mac. This allows us to use overlay scrollbars on future versions of Mac OS X. * wtf/Platform.h: 2011-06-08 Sailesh Agrawal <sail@chromium.org>; Reviewed by Mihai Parparita. Chromium Mac: Enable overlay scrollbars https://bugs.webkit.org/show_bug.cgi?id=59756 Sync ScrollbarThemeChromiumMac.mm/.h with ScrollbarThemeMac.mm to pick up support for overlay scrollbars. The only changes are renaming ScrollbarThemeMac to ScrollbarThemeChromiumMac and using runtime checks instead of #ifdef's. No new tests, since this code is only enabled on future versions of Mac OS X. * platform/chromium/ScrollAnimatorChromiumMac.mm: All changes to this file except in scroll() were to swap #if USE(WK_SCROLLBAR_PAINTER) with runtime checks. (WebCore::ScrollAnimatorChromiumMac::ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::~ScrollAnimatorChromiumMac): (WebCore::ScrollAnimatorChromiumMac::notityPositionChanged): (WebCore::ScrollAnimatorChromiumMac::contentAreaWillPaint): (WebCore::ScrollAnimatorChromiumMac::mouseEnteredContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseExitedContentArea): (WebCore::ScrollAnimatorChromiumMac::mouseMovedInContentArea): (WebCore::ScrollAnimatorChromiumMac::willStartLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentsResized): (WebCore::ScrollAnimatorChromiumMac::willEndLiveResize): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidShow): (WebCore::ScrollAnimatorChromiumMac::contentAreaDidHide): (WebCore::ScrollAnimatorChromiumMac::didBeginScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didEndScrollGesture): (WebCore::ScrollAnimatorChromiumMac::didAddVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveVerticalScrollbar): (WebCore::ScrollAnimatorChromiumMac::didAddHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::willRemoveHorizontalScrollbar): (WebCore::ScrollAnimatorChromiumMac::cancelAnimations): * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm: (preferredScrollerStyle): Disabled overlay scrollbar styles due to trailing artifacts. (wkScrollbarPainterPaint): Fixed a problem where the scrollbar track wasn't being drawn. (wkScrollbarPainterKnobRect): Implemented a previously unimplemented function. (wkSetScrollbarPainterKnobStyle): Implemented a function that's now supported by the latest Mac OS X seeds. (isScrollbarOverlayAPIAvailable): Enabled new scrollbar code. * platform/chromium/ScrollbarThemeChromiumMac.h: * platform/chromium/ScrollbarThemeChromiumMac.mm: Sync with ScrollbarThemeMac.mm. (WebCore::scrollbarMap): (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::updateArrowPlacement): (WebCore::ScrollbarThemeChromiumMac::registerScrollbar): (WebCore::ScrollbarThemeChromiumMac::unregisterScrollbar): (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::painterForScrollbar): (WebCore::ScrollbarThemeChromiumMac::scrollbarThickness): (WebCore::ScrollbarThemeChromiumMac::usesOverlayScrollbars): (WebCore::ScrollbarThemeChromiumMac::hasButtons): (WebCore::ScrollbarThemeChromiumMac::hasThumb): (WebCore::buttonRepaintRect): (WebCore::ScrollbarThemeChromiumMac::minimumThumbLength): (WebCore::ScrollbarThemeChromiumMac::shouldDragDocumentInsteadOfThumb): (WebCore::toScrollbarPainterKnobStyle): (WebCore::ScrollbarThemeChromiumMac::paint): TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1959 lines, -117 lines) Patch
M Source/JavaScriptCore/ChangeLog View 1 chunk +633 lines, -0 lines 0 comments Download
M Source/JavaScriptCore/wtf/Platform.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +1119 lines, -0 lines 0 comments Download
M Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm View 2 chunks +64 lines, -84 lines 0 comments Download
M Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm View 7 chunks +10 lines, -9 lines 0 comments Download
M Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.h View 4 chunks +6 lines, -0 lines 0 comments Download
M Source/WebCore/platform/chromium/ScrollbarThemeChromiumMac.mm View 12 chunks +125 lines, -24 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
9 years, 6 months ago (2011-06-09 18:05:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698