Issue 7134049: Initialize RenderWidget's compositing_surface_ to kNullPluginWindow. This avoids passing garbage ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7134049: Initialize RenderWidget's compositing_surface_ to kNullPluginWindow. This avoids passing garbage ... (Closed)

Created:
9 years, 6 months ago by Stephen White

Modified:
9 years, 6 months ago

Reviewers:
beng (no_code_reviews), Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Initialize RenderWidget's compositing_surface_ to kNullPluginWindow. This avoids passing garbage down to the GL layers in the test case attached to the bug below. Note that this does not fix the bug, but will avoid potential memory corruption and suppress spurious window system errors. BUG=80703 TEST=run the "canvas-popup.html" test case in the bug. check the chrome_debug.log to see that no EGL or X errors are present. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88563

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	content/renderer/render_widget.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Stephen White

Second try.. this time using kNullPluginWindow to appease the ARM build.

9 years, 6 months ago (2011-06-09 17:58:22 UTC) #1

LGTM

Expand Messages | Collapse Messages