Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 7134043: Moved non-architecture-specific GetFooCodeStub functions to ic.cc, removing (Closed)

Created:
9 years, 6 months ago by Sven Panne
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Moved non-architecture-specific GetFooCodeStub functions to ic.cc, removing duplicate code and the need for 2 free-floating function prototypes. Committed: http://code.google.com/p/v8/source/detail?r=8240

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -70 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/ic.cc View 4 chunks +4 lines, -14 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
9 years, 6 months ago (2011-06-09 13:11:32 UTC) #1
Søren Thygesen Gjesse
9 years, 6 months ago (2011-06-09 13:18:16 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698