Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 7134039: GYP: Make the ARM simulator build with GYP again (Closed)

Created:
9 years, 6 months ago by Søren Thygesen Gjesse
Modified:
9 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

GYP: Make the ARM simulator build with GYP again Updated the armu.gypi to set values for variables which does not have a default. These variables was recently added to v8.gyp. Moved the what will be shared between building the v8 library and the cctests to a separate include file. For now this file is currently only used by cctest.gyp. the reason is that the cctests are not just using the API but also internal functions so the C++ defines and optons needs to be the same when compiling the cctests files as when compiling the v8 library files. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=8239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -32 lines) Patch
M build/armu.gypi View 2 chunks +5 lines, -1 line 0 comments Download
A build/v8-features.gypi View 1 chunk +125 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +2 lines, -31 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 6 months ago (2011-06-09 09:39:58 UTC) #1
Jakob Kummerow
9 years, 6 months ago (2011-06-09 11:47:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698