Make an inserted selected tab selected before calling TabInsertedAt on observers.

chrome/browser/extensions/extension_tabs_module.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tabs_module.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 174 matching lines @@
     NavigationEntry* entry = contents->controller().GetActiveEntry();
     if (entry) {
       if (entry->favicon().is_valid())
         result->SetString(keys::kFaviconUrlKey, entry->favicon().url().spec());
     }
   }
 
   return result;
 }
 
+DictionaryValue* ExtensionTabUtil::CreateTabValueActive(
+    const TabContents* contents, bool active) {

[sky, 2011/06/10 14:58:59]

each param on its own line.

[Yoyo Zhou, 2011/06/10 18:04:01]

Done here and elsewhere.

+  DictionaryValue* result = ExtensionTabUtil::CreateTabValue(contents);
+  result->SetBoolean(keys::kSelectedKey, active);
+  return result;
+}
+
 // if |populate| is true, each window gets a list property |tabs| which contains
 // fully populated tab objects.
 DictionaryValue* ExtensionTabUtil::CreateWindowValue(const Browser* browser,
                                                      bool populate_tabs) {
   DCHECK(browser);
   DCHECK(browser->window());
   DictionaryValue* result = new DictionaryValue();
   result->SetInteger(keys::kIdKey, ExtensionTabUtil::GetWindowId(browser));
   result->SetBoolean(keys::kIncognitoKey,
                      browser->profile()->IsOffTheRecord());
@@ skipping 408 matching lines @@
   if (update_props->HasKey(keys::kHeightKey)) {
     EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
         keys::kHeightKey,
         &bounds_val));
     bounds.set_height(bounds_val);
     set_bounds = true;
   }
   if (set_bounds)
     browser->window()->SetBounds(bounds);
 
-  bool selected_val = false;
+  bool active_val = false;
   if (update_props->HasKey(keys::kFocusedKey)) {
     EXTENSION_FUNCTION_VALIDATE(update_props->GetBoolean(
-        keys::kFocusedKey, &selected_val));
-    if (selected_val)
+        keys::kFocusedKey, &active_val));
+    if (active_val)
       browser->window()->Activate();
     else
       browser->window()->Deactivate();
   }
 
   result_.reset(ExtensionTabUtil::CreateWindowValue(browser, false));
 
   return true;
 }
 
@@ skipping 705 matching lines @@
   // called for every API call the extension made.
   GotLanguage(language);
 }
 
 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
   result_.reset(Value::CreateStringValue(language.c_str()));
   SendResponse(true);
 
   Release();  // Balanced in Run()
 }