Disable scalling of InfoBar icon

Disable scalling of InfoBar icon

This change disables scaling of infobar icons. With this change it should be easier to catch clipping issues due to incorrectly sized infobar icons.

BUG=80432
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88424

[Robert Sesek, 2011-06-08 20:29:40]

LGTM

[Peter Kasting, 2011-06-08 20:33:43]

http://codereview.chromium.org/7134024/diff/1/chrome/browser/tab_contents/inf...
File chrome/browser/tab_contents/infobar.cc (right):

http://codereview.chromium.org/7134024/diff/1/chrome/browser/tab_contents/inf...
chrome/browser/tab_contents/infobar.cc:37: int GetInfoBarIconSizePixels() {
Why are you using a function instead of a constant?

[Peter Kasting, 2011-06-08 20:34:52]

Actually this whole change just seems off.  My intent was that you remove the
scaling and just draw the icon at its normal size, which is what the existing
views code did.  Instead we're hardcoding 32 somewhere.  This isn't right.

[sail, 2011-06-08 20:35:13]

http://codereview.chromium.org/7134024/diff/1/chrome/browser/tab_contents/inf...
File chrome/browser/tab_contents/infobar.cc (right):

http://codereview.chromium.org/7134024/diff/1/chrome/browser/tab_contents/inf...
chrome/browser/tab_contents/infobar.cc:37: int GetInfoBarIconSizePixels() {
On 2011/06/08 20:33:43, Peter Kasting wrote:
> Why are you using a function instead of a constant?

does this look ok?
   extern const int kInfoBarIconSizePixels;

[sail, 2011-06-08 20:37:03]

On 2011/06/08 20:34:52, Peter Kasting wrote:
> Actually this whole change just seems off.  My intent was that you remove the
> scaling and just draw the icon at its normal size, which is what the existing
> views code did.  Instead we're hardcoding 32 somewhere.  This isn't right.

I agree that what we're doing right now is fine.
How about just adding a DCHECK() to make sure that the icon is 32x32?

[Peter Kasting, 2011-06-08 20:43:16]

On 2011/06/08 20:37:03, sail wrote:
> I agree that what we're doing right now is fine.

...In cases where we're not scaling.  Anything that scales shouldn't scale.

> How about just adding a DCHECK() to make sure that the icon is 32x32?

If you want.  I wouldn't even worry about this.

[sail, 2011-06-08 21:42:57]

Removed changes to the Linux and Windows code.

[Peter Kasting, 2011-06-08 22:12:22]

LGTM.  (Wish you could say "NSImageScaleNone" instead of "2".)

[commit-bot: I haz the power, 2011-06-08 22:35:38]

Change committed as 88424