Issue 7134018: Don't wrap system headers with extern "C"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7134018: Don't wrap system headers with extern "C" (Closed)

Created:
9 years, 6 months ago by eaeltsin

Modified:
9 years, 6 months ago

Reviewers:
khim, pasko-google - do not use, krasin

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master

Visibility:
Public.

Description

Don't wrap system headers with extern "C" Implicit wrapping of system header files with extern "C" is controlled by NO_IMPLICIT_EXTERN_C macro. This macro is defined in gcc/config/linux.h (gcc/config/gnu-user.h in newer versions of gcc), which included on x86 linux systems (see gcc/config.gcc). This change defines this macro for nacl. BUG=http://code.google.com/p/nativeclient/issues/detail?id=1896 TEST=see the bug R=pasko@google.com,krasin@google.com Committed: http://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=bbb8426

Patch Set 1 #

Total comments: 2

Patch Set 2 : Ready for commit #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	gcc/config/i386/nacl.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pasko-google - do not use

LGTM http://codereview.chromium.org/7134018/diff/1/gcc/config/i386/nacl.h File gcc/config/i386/nacl.h (right): http://codereview.chromium.org/7134018/diff/1/gcc/config/i386/nacl.h#newcode40 gcc/config/i386/nacl.h:40: /* Don't assume anything about the header files. ...

9 years, 6 months ago (2011-06-08 14:37:25 UTC) #2

eaeltsin

9 years, 6 months ago (2011-06-08 15:34:22 UTC) #4

http://codereview.chromium.org/7134018/diff/1/gcc/config/i386/nacl.h
File gcc/config/i386/nacl.h (right):

http://codereview.chromium.org/7134018/diff/1/gcc/config/i386/nacl.h#newcode40
gcc/config/i386/nacl.h:40: /* Don't assume anything about the header files.  */
On 2011/06/08 14:37:25, pasko wrote:
> please, remove this useless comment

Rephrased.

Expand Messages | Collapse Messages