Make safe browsing work in a multi-profile environment.

chrome/browser/browser_process_impl.cc

Index: chrome/browser/browser_process_impl.cc
===================================================================
--- chrome/browser/browser_process_impl.cc	(revision 90024)
+++ chrome/browser/browser_process_impl.cc	(working copy)
@@ -1005,7 +1005,9 @@
     profile_manager()->GetDefaultProfile() : NULL;

[mattm, 2011/06/23 21:40:40]

Did you see my comment about the client side phishing detection?  This will need
some changes too.  

I guess what you'd want to do is remove the pref check from here and then
somehow pipe the value into ChromeContentRendererClient::RenderViewCreated to
choose whether to do the PhishingClassifierDelegate::Create. 
(ChromeContentBrowserClient::AppendExtraCommandLineSwitches does this right now
by passing kDisableClientSidePhishingDetection when the service object hasn't
been created, so I think you'd just have to move the pref check there.)


(And like SafeBrowsingService, change this in the next CL to only start the
ClientSideDetectionService when needed.)

[Miranda Callahan, 2011/07/07 17:35:50]

Done.

   if (IsSafeBrowsingDetectionServiceEnabled() &&
       PathService::Get(chrome::DIR_USER_DATA, &model_file_dir) &&
-      profile && profile->GetRequestContext()) {
+      profile &&
+      profile->GetPrefs()->GetBoolean(prefs::kSafeBrowsingEnabled) &&
+      profile->GetRequestContext()) {
     safe_browsing_detection_service_.reset(
         safe_browsing::ClientSideDetectionService::Create(
             model_file_dir, profile->GetRequestContext()));

[mattm, 2011/06/23 21:40:40]

I think this should use the system request context.

[Miranda Callahan, 2011/07/07 17:35:50]

Done.