Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/ast.cc

Issue 7134014: Stop using with explicitly to implement try/catch. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.h ('k') | src/full-codegen.cc » ('j') | src/parser.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 } 286 }
287 } 287 }
288 // Add key to the table. 288 // Add key to the table.
289 table->Lookup(key, hash, true); 289 table->Lookup(key, hash, true);
290 } 290 }
291 } 291 }
292 292
293 293
294 void TargetCollector::AddTarget(Label* target) { 294 void TargetCollector::AddTarget(Label* target) {
295 // Add the label to the collector, but discard duplicates. 295 // Add the label to the collector, but discard duplicates.
296 int length = targets_->length(); 296 int length = targets_.length();
297 for (int i = 0; i < length; i++) { 297 for (int i = 0; i < length; i++) {
298 if (targets_->at(i) == target) return; 298 if (targets_[i] == target) return;
299 } 299 }
300 targets_->Add(target); 300 targets_.Add(target);
301 } 301 }
302 302
303 303
304 bool UnaryOperation::ResultOverwriteAllowed() { 304 bool UnaryOperation::ResultOverwriteAllowed() {
305 switch (op_) { 305 switch (op_) {
306 case Token::BIT_NOT: 306 case Token::BIT_NOT:
307 case Token::SUB: 307 case Token::SUB:
308 return true; 308 return true;
309 default: 309 default:
310 return false; 310 return false;
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 bool TryCatchStatement::IsInlineable() const { 385 bool TryCatchStatement::IsInlineable() const {
386 return false; 386 return false;
387 } 387 }
388 388
389 389
390 bool TryFinallyStatement::IsInlineable() const { 390 bool TryFinallyStatement::IsInlineable() const {
391 return false; 391 return false;
392 } 392 }
393 393
394 394
395 bool CatchExtensionObject::IsInlineable() const {
396 return false;
397 }
398
399
400 bool DebuggerStatement::IsInlineable() const { 395 bool DebuggerStatement::IsInlineable() const {
401 return false; 396 return false;
402 } 397 }
403 398
404 399
405 bool Throw::IsInlineable() const { 400 bool Throw::IsInlineable() const {
406 return exception()->IsInlineable(); 401 return exception()->IsInlineable();
407 } 402 }
408 403
409 404
(...skipping 737 matching lines...) Expand 10 before | Expand all | Expand 10 after
1147 int pos) 1142 int pos)
1148 : label_(label), 1143 : label_(label),
1149 statements_(statements), 1144 statements_(statements),
1150 position_(pos), 1145 position_(pos),
1151 compare_type_(NONE), 1146 compare_type_(NONE),
1152 compare_id_(AstNode::GetNextId()), 1147 compare_id_(AstNode::GetNextId()),
1153 entry_id_(AstNode::GetNextId()) { 1148 entry_id_(AstNode::GetNextId()) {
1154 } 1149 }
1155 1150
1156 } } // namespace v8::internal 1151 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.h ('k') | src/full-codegen.cc » ('j') | src/parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698