Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 7134014: Stop using with explicitly to implement try/catch. (Closed)

Created:
9 years, 6 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Stop using with explicitly to implement try/catch. The AST for TryCatch gives us enough structure that we do not need to expand it to explicitly include a with. Try/catch is still handled the same as before at runtime. R=ager@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=8224

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -173 lines) Patch
M src/ast.h View 6 chunks +9 lines, -37 lines 0 comments Download
M src/ast.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/full-codegen.cc View 4 chunks +10 lines, -35 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/parser.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/parser.cc View 8 chunks +48 lines, -48 lines 3 comments Download
M src/prettyprinter.cc View 7 chunks +8 lines, -27 lines 0 comments Download
M src/rewriter.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
This needs void push(Handle<Object) for the other platforms before committing. http://codereview.chromium.org/7134014/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/7134014/diff/1/src/parser.cc#newcode2110 ...
9 years, 6 months ago (2011-06-08 12:47:48 UTC) #1
Mads Ager (chromium)
9 years, 6 months ago (2011-06-08 13:27:46 UTC) #2
LGTM

http://codereview.chromium.org/7134014/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/7134014/diff/1/src/parser.cc#newcode2092
src/parser.cc:2092: // Rewrite the catch body B to a single statement block
Indentation.

http://codereview.chromium.org/7134014/diff/1/src/parser.cc#newcode2110
src/parser.cc:2110: inner_finally->AddStatement(new(zone())
WithExitStatement());
On 2011/06/08 12:47:49, Kevin Millikin wrote:
> I'm still using WithExitStatement here.  I'll rename it to something like
> PopContextStatement (suggestions?) in a later change.

PopContextStatement seems reasonable to me.

Powered by Google App Engine
This is Rietveld 408576698