content/browser/renderer_host/render_view_host.cc - Issue 7134008: Revert 88151 (see crbug.com/85296) - Fix user-after-free error with ObserverList. The problem is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host.cc

Issue 7134008: Revert 88151 (see crbug.com/85296) - Fix user-after-free error with ObserverList. The problem is... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_view_host.cc

===================================================================

--- content/browser/renderer_host/render_view_host.cc (revision 88283)

+++ content/browser/renderer_host/render_view_host.cc (working copy)

@@ -633,11 +633,15 @@

if (!content::SwappedOutMessages::CanHandleWhileSwappedOut(msg))

return true;

- ObserverListBase<RenderViewHostObserver>::Iterator it(observers_);

- RenderViewHostObserver* observer;

- while ((observer = it.GetNext()) != NULL) {

- if (observer->OnMessageReceived(msg))

- return true;

+ {

+ // delegate_->OnMessageReceived can end up deleting |this|, in which case

+ // the destructor for ObserverListBase::Iterator would access the deleted

+ // observers_.

+ ObserverListBase<RenderViewHostObserver>::Iterator it(observers_);

+ RenderViewHostObserver* observer;

+ while ((observer = it.GetNext()) != NULL)

+ if (observer->OnMessageReceived(msg))

+ return true;

}

if (delegate_->OnMessageReceived(msg))

« no previous file with comments | « base/observer_list_unittest.cc ('k') | no next file » | no next file with comments »