Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 7134004: file manager: clean up rename click detection (Closed)

Created:
9 years, 6 months ago by rginda
Modified:
9 years, 6 months ago
Reviewers:
achuithb
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org
Visibility:
Public.

Description

file manager: clean up rename click detection This patch changes rename click detection so that a user must slow double click on the *same* file. The previous code usually required users to click on the same file, but relied on a side effect of the list control (that clicking on a new file resets the selection), which didn't always work. BUG=chromium-os:16270 TEST=manual testing on chromeos-chrome on linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88348

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 2 chunks +11 lines, -8 lines 1 comment Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +6 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
rginda
http://codereview.chromium.org/7134004/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (left): http://codereview.chromium.org/7134004/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#oldcode1841 chrome/browser/resources/file_manager/js/file_manager.js:1841: window.label = label; This is some debugging code that ...
9 years, 6 months ago (2011-06-07 22:58:14 UTC) #1
achuithb
9 years, 6 months ago (2011-06-08 00:57:34 UTC) #2
On 2011/06/07 22:58:14, rginda wrote:
>
http://codereview.chromium.org/7134004/diff/1/chrome/browser/resources/file_m...
> File chrome/browser/resources/file_manager/js/file_manager.js (left):
> 
>
http://codereview.chromium.org/7134004/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/file_manager.js:1841: window.label =
> label;
> This is some debugging code that slipped in in a previous commit.
> 
>
http://codereview.chromium.org/7134004/diff/1/chrome/browser/resources/file_m...
> File chrome/browser/resources/file_manager/js/mock_chrome.js (right):
> 
>
http://codereview.chromium.org/7134004/diff/1/chrome/browser/resources/file_m...
> chrome/browser/resources/file_manager/js/mock_chrome.js:188: chrome.test = {
> Needed to run harness.html after jamescook's recent checkin.


LGTM

Powered by Google App Engine
This is Rietveld 408576698