Issue 7131008: Clang needs dtor in the cc file (build fix)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7131008: Clang needs dtor in the cc file (build fix) (Closed)

Created:
9 years, 6 months ago by cpu%chromium.org

Modified:
9 years, 6 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Clang needs dtor in the cc file (build fix) BUG=none TEST=one TBR=shess Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88145

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	base/version.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	base/version.cc	View	1	2 chunks	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

9 years, 6 months ago (2011-06-07 17:52:25 UTC) #1

LGTM.  Thanks!

http://codereview.chromium.org/7131008/diff/1003/base/version.cc
File base/version.cc (right):

http://codereview.chromium.org/7131008/diff/1003/base/version.cc#newcode1
base/version.cc:1: // Copyright (c) 2011 The Chromium Authors. All rights
reserved.
Sneaky.  I like it.

Expand Messages | Collapse Messages