Chromium Code Reviews

Issue 7131006: Add failing test case for bug 1434 (Closed)

Created:
9 years, 6 months ago by danno
Modified:
9 years, 6 months ago
Reviewers:
Mads Ager (chromium)
CC:
v8-dev
Visibility:
Public.

Description

Add failing test case for bug 1434 BUG=1434 TEST=test/mjsunit/bugs/bug-1434.js

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+42 lines, -0 lines)
A test/mjsunit/bugs/bug-1434.js View 1 chunk +40 lines, -0 lines 1 comment
M test/mjsunit/mjsunit.status View 1 chunk +2 lines, -0 lines 0 comments

Messages

Total messages: 2 (0 generated)
danno
Please review
9 years, 6 months ago (2011-06-07 16:22:22 UTC) #1
Mads Ager (chromium)
9 years, 6 months ago (2011-06-07 18:07:56 UTC) #2
LGTM, thanks

http://codereview.chromium.org/7131006/diff/1/test/mjsunit/bugs/bug-1434.js
File test/mjsunit/bugs/bug-1434.js (right):

http://codereview.chromium.org/7131006/diff/1/test/mjsunit/bugs/bug-1434.js#n...
test/mjsunit/bugs/bug-1434.js:31: if (a === b) {
Is the conditional like this needed or does it fail if the body is just "return
a === b" as well? That is, is it the comparison of the control-flow that goes
wrong?

Powered by Google App Engine