Issue 7131006: Add failing test case for bug 1434

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7131006: Add failing test case for bug 1434 (Closed)

Created:
9 years, 6 months ago by danno

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Add failing test case for bug 1434 BUG=1434 TEST=test/mjsunit/bugs/bug-1434.js

Patch Set 1 #

Total comments: 1

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	A	test/mjsunit/bugs/bug-1434.js	View		1 chunk	+40 lines, -0 lines	1 comment	Download
	M	test/mjsunit/mjsunit.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 6 months ago (2011-06-07 18:07:56 UTC) #2

LGTM, thanks

http://codereview.chromium.org/7131006/diff/1/test/mjsunit/bugs/bug-1434.js
File test/mjsunit/bugs/bug-1434.js (right):

http://codereview.chromium.org/7131006/diff/1/test/mjsunit/bugs/bug-1434.js#n...
test/mjsunit/bugs/bug-1434.js:31: if (a === b) {
Is the conditional like this needed or does it fail if the body is just "return
a === b" as well? That is, is it the comparison of the control-flow that goes
wrong?

Expand Messages | Collapse Messages