Make infobar background gray

Make infobar background gray 

Currently page action infobars are blue on Windows and Linux and yellow on Mac. This change makes it gray on all platforms. 

Screenshots: 
http://www.dropmocks.com/mVNOW 

Also see this CL: 
http://codereview.chromium.org/7031069/ 

BUG=80432
TEST=Ran on Mac and Linux. Windows pending.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88205

[Nico, 2011-06-07 05:50:26]

How does this look on linux with unity?

I couldn't find the word "grey" or "gray" anywhere in
http://code.google.com/p/chromium/issues/detail?id=80432

[Nico, 2011-06-07 05:50:37]

s/unity/ubuntu theme/

[sail, 2011-06-07 06:02:19]

On 2011/06/07 05:50:26, Nico wrote:
> How does this look on linux with unity?
> 
> I couldn't find the word "grey" or "gray" anywhere in
> http://code.google.com/p/chromium/issues/detail?id=80432

Added more screenshots.

This doesn't really fix bug 80432. As a part of my fix for 80432 I'm changing
the style of the infobar. The idea is that:
  - infobar background is now gray scale
  - the infobar icon is now also grayscale

[Nico, 2011-06-07 06:03:27]

> This doesn't really fix bug 80432. As a part of my fix for 80432 I'm
> changing
> the style of the infobar. The idea is that:
>  - infobar background is now gray scale
>  - the infobar icon is now also grayscale

I guess my point is that you should add a comment to the bug saying a)
that you're doing this b) why c) that ux leads are fine with it.

[Nico, 2011-06-07 06:09:33]

LGTM with moved function.

http://codereview.chromium.org/7130001/diff/1001/ui/gfx/skia_utils_mac.h
File ui/gfx/skia_utils_mac.h (right):

http://codereview.chromium.org/7130001/diff/1001/ui/gfx/skia_utils_mac.h#newc...
ui/gfx/skia_utils_mac.h:16: NSColor* SkColorToNSColor(SkColor color);
Why not put this in skia/ext/skia_utils_mac.h?

http://codereview.chromium.org/7130001/diff/1001/ui/gfx/skia_utils_mac.mm
File ui/gfx/skia_utils_mac.mm (right):

http://codereview.chromium.org/7130001/diff/1001/ui/gfx/skia_utils_mac.mm#new...
ui/gfx/skia_utils_mac.mm:9: NSColor* SkColorToNSColor(SkColor color) {
SkColorToCalibratedNSColor I think

[sail, 2011-06-07 06:20:44]

http://codereview.chromium.org/7130001/diff/1001/ui/gfx/skia_utils_mac.h
File ui/gfx/skia_utils_mac.h (right):

http://codereview.chromium.org/7130001/diff/1001/ui/gfx/skia_utils_mac.h#newc...
ui/gfx/skia_utils_mac.h:16: NSColor* SkColorToNSColor(SkColor color);
On 2011/06/07 06:09:33, Nico wrote:
> Why not put this in skia/ext/skia_utils_mac.h?

Done.
Good idea.

http://codereview.chromium.org/7130001/diff/1001/ui/gfx/skia_utils_mac.mm
File ui/gfx/skia_utils_mac.mm (right):

http://codereview.chromium.org/7130001/diff/1001/ui/gfx/skia_utils_mac.mm#new...
ui/gfx/skia_utils_mac.mm:9: NSColor* SkColorToNSColor(SkColor color) {
On 2011/06/07 06:09:33, Nico wrote:
> SkColorToCalibratedNSColor I think

Done.

[Robert Sesek, 2011-06-07 14:48:52]

LGTM

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/cocoa/info...
File chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h (right):

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h:10: #include
"chrome/browser/tab_contents/infobar_delegate.h"
nit: alphabetize

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h:17: -
(void)setInfobarType:(InfoBarDelegate::Type)infobarType;
Add a comment stating that this will change the gradient.

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h
File chrome/browser/ui/infobar.h (right):

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h#...
chrome/browser/ui/infobar.h:11: 
Namespace level comment that explains what these functions are for.

[tfarina, 2011-06-07 15:06:26]

+Peter for review.

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h
File chrome/browser/ui/infobar.h (right):

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h#...
chrome/browser/ui/infobar.h:12: namespace infobar {
please, could you rename this file to infobar_util/infobar_utils? And change the
namespace according? There are too many infobar.* files already.

[Peter Kasting, 2011-06-07 18:13:13]

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h
File chrome/browser/ui/infobar.h (right):

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h#...
chrome/browser/ui/infobar.h:12: namespace infobar {
On 2011/06/07 15:06:27, tfarina wrote:
> please, could you rename this file to infobar_util/infobar_utils? And change
the
> namespace according? There are too many infobar.* files already.

I would prefer this to be named infobar_background.*, have no namespace inside,
and live in chrome/browser/tab_contents or chrome/browser/ui/infobars.

[sail, 2011-06-07 19:21:02]

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/cocoa/info...
File chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h (right):

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h:10: #include
"chrome/browser/tab_contents/infobar_delegate.h"
On 2011/06/07 14:48:53, rsesek wrote:
> nit: alphabetize

Done.

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/cocoa/info...
chrome/browser/ui/cocoa/infobars/infobar_gradient_view.h:17: -
(void)setInfobarType:(InfoBarDelegate::Type)infobarType;
On 2011/06/07 14:48:53, rsesek wrote:
> Add a comment stating that this will change the gradient.

Done.

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h
File chrome/browser/ui/infobar.h (right):

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h#...
chrome/browser/ui/infobar.h:11: 
On 2011/06/07 14:48:53, rsesek wrote:
> Namespace level comment that explains what these functions are for.

Moved to tab_contents/infobar.h instead.

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h#...
chrome/browser/ui/infobar.h:12: namespace infobar {
On 2011/06/07 15:06:27, tfarina wrote:
> please, could you rename this file to infobar_util/infobar_utils? And change
the
> namespace according? There are too many infobar.* files already.
Moved to tab_contents/infobar.h instead.

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h#...
chrome/browser/ui/infobar.h:12: namespace infobar {
On 2011/06/07 18:13:13, Peter Kasting wrote:
> On 2011/06/07 15:06:27, tfarina wrote:
> > please, could you rename this file to infobar_util/infobar_utils? And change
> the
> > namespace according? There are too many infobar.* files already.
> 
> I would prefer this to be named infobar_background.*, have no namespace
inside,
> and live in chrome/browser/tab_contents or chrome/browser/ui/infobars.

Done.

[Robert Sesek, 2011-06-07 20:03:50]

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h
File chrome/browser/ui/infobar.h (right):

http://codereview.chromium.org/7130001/diff/5004/chrome/browser/ui/infobar.h#...
chrome/browser/ui/infobar.h:12: namespace infobar {
On 2011/06/07 18:13:13, Peter Kasting wrote:
> I would prefer this to be named infobar_background.*, have no namespace
inside,

I actually prefer the namespace rather than global functions. Why would you
prefer no namespace? This seems to be the opposite direction Chromium is going
with chrome/content refactoring.

[Peter Kasting, 2011-06-07 20:38:55]

On 2011/06/07 20:03:50, rsesek wrote:
> I actually prefer the namespace rather than global functions.

Don't worry about this comment.  As soon as I made it I suggested something
better to sail.  These functions will become static inside an appropriate class
soon.