Issue 7129071: Merge 88800 - Refactor UpgradeDetector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7129071: Merge 88800 - Refactor UpgradeDetector. (Closed)

Created:
9 years, 6 months ago by xiyuan

Modified:
9 years, 6 months ago

Reviewers:
DaveMoore

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/782/src/

Visibility:
Public.

Description

Merge 88800 - Refactor UpgradeDetector. - Move peroidically timer based detection code into UpgradeDetectorImpl for use on non-ChromeOS platform; - Implement ChromeOS upgrade detection via UpdateLibrary observer and apply a slightly different advisory timing for showing the badges (show green arrow immediately on upgrade detected, then 2, 4, 7 days for yellow, red and orange color); BUG=chromium-os:16146 TEST=Verify fix for chromium-os:16146. Review URL: http://codereview.chromium.org/7046096 TBR=davemoore@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88801

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -281 lines)			Patch
A +	chrome/browser/chromeos/upgrade_detector_chromeos.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/chromeos/upgrade_detector_chromeos.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/upgrade_detector.h	View	3 chunks	+15 lines, -29 lines	0 comments	Download
M	chrome/browser/upgrade_detector.cc	View	2 chunks	+3 lines, -256 lines	0 comments	Download
A +	chrome/browser/upgrade_detector_impl.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/upgrade_detector_impl.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages