Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: base/sys_string_conversions_unittest.cc

Issue 7129056: Cleanup in base/test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reverted, rebased again Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.gyp ('k') | base/test/scoped_locale.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_string_conversions_unittest.cc
diff --git a/base/sys_string_conversions_unittest.cc b/base/sys_string_conversions_unittest.cc
index fa711f38d2eca69ae3129ae61f0e5e19b9862992..f12051795386216d351205ad26da17f62f339d27 100644
--- a/base/sys_string_conversions_unittest.cc
+++ b/base/sys_string_conversions_unittest.cc
@@ -7,7 +7,7 @@
#include "base/basictypes.h"
#include "base/string_piece.h"
-#include "base/test/test_util.h"
+#include "base/test/scoped_locale.h"
#include "base/utf_string_conversions.h"
#include "base/sys_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -77,7 +77,7 @@ TEST(SysStrings, SysUTF8ToWide) {
TEST(SysStrings, SysWideToNativeMB) {
using base::SysWideToNativeMB;
- base::ScopedSetLocale locale("en_US.utf-8");
+ base::ScopedLocale locale("en_US.utf-8");
EXPECT_EQ("Hello, world", SysWideToNativeMB(L"Hello, world"));
EXPECT_EQ("\xe4\xbd\xa0\xe5\xa5\xbd", SysWideToNativeMB(L"\x4f60\x597d"));
@@ -108,7 +108,7 @@ TEST(SysStrings, SysWideToNativeMB) {
// We assume the test is running in a UTF8 locale.
TEST(SysStrings, SysNativeMBToWide) {
using base::SysNativeMBToWide;
- base::ScopedSetLocale locale("en_US.utf-8");
+ base::ScopedLocale locale("en_US.utf-8");
EXPECT_EQ(L"Hello, world", SysNativeMBToWide("Hello, world"));
EXPECT_EQ(L"\x4f60\x597d", SysNativeMBToWide("\xe4\xbd\xa0\xe5\xa5\xbd"));
// >16 bits
@@ -162,7 +162,7 @@ static const wchar_t* const kConvertRoundtripCases[] = {
TEST(SysStrings, SysNativeMBAndWide) {
- base::ScopedSetLocale locale("en_US.utf-8");
+ base::ScopedLocale locale("en_US.utf-8");
for (size_t i = 0; i < arraysize(kConvertRoundtripCases); ++i) {
std::wstring wide = kConvertRoundtripCases[i];
std::wstring trip = base::SysNativeMBToWide(base::SysWideToNativeMB(wide));
« no previous file with comments | « base/base.gyp ('k') | base/test/scoped_locale.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698