chrome/browser/browser_main.cc - Issue 7129046: Makes Chrome crash on start if we can't init the common controls. I'm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_main.cc

Issue 7129046: Makes Chrome crash on start if we can't init the common controls. I'm (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browser_main.cc

diff --git a/chrome/browser/browser_main.cc b/chrome/browser/browser_main.cc

index fd65ad6a4b855ba0085005dae50e3e86f776a0db..adae5d6d8b865d0b4d5e96bf15e6b7f380732776 100644

--- a/chrome/browser/browser_main.cc

+++ b/chrome/browser/browser_main.cc

@@ -1017,7 +1017,8 @@ void InitializeToolkit(const MainFunctionParams& parameters) {

INITCOMMONCONTROLSEX config;

config.dwSize = sizeof(config);

config.dwICC = ICC_WIN95_CLASSES;

- InitCommonControlsEx(&config);

+ if (!InitCommonControlsEx(&config))

+ LOG_GETLASTERROR(FATAL);

#endif

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »