Makes Chrome crash on start if we can't init the common controls. I'm

Makes Chrome crash on start if we can't init the common controls. I'm
curious to see if this impacts the crashes we're getting when trying
to create a tooltip.

BUG=82193
TEST=none
R=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88666

[Ben Goodger (Google), 2011-06-09 21:30:48]

LGTM

On Thu, Jun 9, 2011 at 2:13 PM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Makes Chrome crash on start if we can't init the common controls. I'm
> curious to see if this impacts the crashes we're getting when trying
> to create a tooltip.
>
> BUG=82193
> TEST=none
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/7129046/<http://codereview.chromium.org/7129...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/browser_main.cc
>
>
> Index: chrome/browser/browser_main.cc
> diff --git a/chrome/browser/browser_main.**cc
> b/chrome/browser/browser_main.**cc
> index fd65ad6a4b855ba0085005dae50e3e**86f776a0db..**
> adae5d6d8b865d0b4d5e96bf15e6b7**f380732776 100644
> --- a/chrome/browser/browser_main.**cc
> +++ b/chrome/browser/browser_main.**cc
> @@ -1017,7 +1017,8 @@ void InitializeToolkit(const MainFunctionParams&
> parameters) {
>   INITCOMMONCONTROLSEX config;
>   config.dwSize = sizeof(config);
>   config.dwICC = ICC_WIN95_CLASSES;
> -  InitCommonControlsEx(&config);
> +  if (!InitCommonControlsEx(&**config))
> +    LOG_GETLASTERROR(FATAL);
>  #endif
>  }
>
>
>
>