Adding a new window type for frameless non-transient top level windows, used by ChromeOS' window ...

views/widget/native_widget_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/native_widget_gtk.h"
 
 #include <gdk/gdk.h>
 #include <gdk/gdkx.h>
 #include <X11/extensions/shape.h>
 #include <X11/Xatom.h>
@@ skipping 162 matching lines @@
 
 void RemoveExposeHandlerIfExists(GtkWidget* widget) {
   gulong id = reinterpret_cast<gulong>(g_object_get_data(G_OBJECT(widget),
                                                          kExposeHandlerIdKey));
   if (id) {
     g_signal_handler_disconnect(G_OBJECT(widget), id);
     g_object_set_data(G_OBJECT(widget), kExposeHandlerIdKey, 0);
   }
 }
 
+GtkWindowType WindowTypeToGtkWindowType(Widget::InitParams::Type type) {
+  switch (type) {
+    case Widget::InitParams::TYPE_WINDOW:
+    case Widget::InitParams::TYPE_WINDOW_FRAMELESS:
+      return GTK_WINDOW_TOPLEVEL;
+    default:

[Daniel Erat, 2011/06/09 05:40:22]

mind changing this to:

case Widget::InitParams::TYPE_POPUP:
case Widget::InitParams::TYPE_MENU:
  return GTK_WINDOW_POPUP;
default:
  NOTREACHED();
  return GTK_WIDGET_TOPLEVEL;

?

+      return GTK_WINDOW_POPUP;
+  }
+  NOTREACHED();
+  return GTK_WINDOW_TOPLEVEL;
+}
+
 }  // namespace
 
 // During drag and drop GTK sends a drag-leave during a drop. This means we
 // have no way to tell the difference between a normal drag leave and a drop.
 // To work around that we listen for DROP_START, then ignore the subsequent
 // drag-leave that GTK generates.
 class NativeWidgetGtk::DropObserver : public MessageLoopForUI::Observer {
  public:
   DropObserver() {}
 
@@ skipping 1476 matching lines @@
 
       // This can't be done without a parent present, or stale data
       // might show up on the screen as seen in
       // http://code.google.com/p/chromium/issues/detail?id=53870
       GtkAllocation alloc =
           { 0, 0, params.bounds.width(), params.bounds.height() };
       gtk_widget_size_allocate(widget_, &alloc);
     }
   } else {
     // Use our own window class to override GtkWindow's move_focus method.
-    widget_ = gtk_views_window_new(
-        params.type == Widget::InitParams::TYPE_WINDOW ? GTK_WINDOW_TOPLEVEL
-                                                       : GTK_WINDOW_POPUP);
+    widget_ = gtk_views_window_new(WindowTypeToGtkWindowType(params.type));
     gtk_widget_set_name(widget_, "views-gtkwidget-window");
     if (transient_to_parent_) {
       gtk_window_set_transient_for(GTK_WINDOW(widget_),
                                    GTK_WINDOW(params.parent));
     }
     GTK_WIDGET_UNSET_FLAGS(widget_, GTK_DOUBLE_BUFFERED);
 
     // Gtk determines the size for windows based on the requested size of the
     // child. For NativeWidgetGtk the child is a fixed. If the fixed ends up
     // with a child widget it's possible the child widget will drive the
@@ skipping 253 matching lines @@
 
   // And now, notify them that they have a brand new parent.
   for (NativeWidgets::iterator it = widgets.begin();
        it != widgets.end(); ++it) {
     (*it)->GetWidget()->NotifyNativeViewHierarchyChanged(true,
                                                          new_parent);
   }
 }
 
 }  // namespace views