Time-based removal of temporary file systems via BrowsingDataRemover

chrome/test/testing_profile.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/testing_profile.h"
 
 #include "build/build_config.h"
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
@@ skipping 41 matching lines @@
 #include "content/browser/mock_resource_context.h"
 #include "content/common/notification_service.h"
 #include "net/base/cookie_monster.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "webkit/database/database_tracker.h"
 #include "webkit/fileapi/file_system_context.h"
 #include "webkit/quota/quota_manager.h"
+#include "webkit/quota/mock_quota_manager.h"
 
 using base::Time;
 using testing::NiceMock;
 using testing::Return;
 
 namespace {
 
 // Task used to make sure history has finished processing a request. Intended
 // for use with BlockUntilHistoryProcessesPendingRequests.
 
@@ skipping 465 matching lines @@
       GetPath(),
       IsOffTheRecord(),
       true,  // Allow file access from files.
       true,  // Unlimited quota.
       NULL);
   }
   return file_system_context_.get();
 }
 
 quota::QuotaManager* TestingProfile::GetQuotaManager() {
-  return NULL;
+  if (!quota_manager_) {
+    quota_manager_ = new quota::MockQuotaManager(

[michaeln, 2011/07/26 22:40:19]

Returning a non-null object is going to have some affect on other tests. To make
this change have less ripple effect, maybe add a setter that only your test
calls, and leave all other tests with a null object. That's more flexible too
since other tests would be free to setup a different 'mock' without impacting
your test.

[Mike West, 2011/07/27 12:49:18]

Fair enough. I wanted to move as much boilerplate as possible out of the tests,
but you're probably right.

+        IsOffTheRecord(),
+        GetPath(),
+        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO),
+        BrowserThread::GetMessageLoopProxyForThread(BrowserThread::DB),
+        GetExtensionSpecialStoragePolicy());
+  }
+  return quota_manager_.get();
 }
 
 BrowserSignin* TestingProfile::GetBrowserSignin() {
   return NULL;
 }
 
 bool TestingProfile::HasCreatedDownloadManager() const {
   return false;
 }
 
@@ skipping 229 matching lines @@
 quota::SpecialStoragePolicy* TestingProfile::GetSpecialStoragePolicy() {
   return GetExtensionSpecialStoragePolicy();
 }
 
 void TestingProfile::DestroyWebDataService() {
   if (!web_data_service_.get())
     return;
 
   web_data_service_->Shutdown();
 }