Time-based removal of temporary file systems via BrowsingDataRemover

chrome/browser/browsing_data_remover.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSING_DATA_REMOVER_H_
 #define CHROME_BROWSER_BROWSING_DATA_REMOVER_H_
 #pragma once
 
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/observer_list.h"
 #include "base/synchronization/waitable_event_watcher.h"
 #include "base/time.h"
 #include "content/browser/appcache/chrome_appcache_service.h"
 #include "content/browser/cancelable_request.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
+#include "webkit/quota/quota_types.h"
 
 class ExtensionSpecialStoragePolicy;
 class IOThread;
 class PluginDataRemover;
 class Profile;
 
 namespace disk_cache {
 class Backend;
 }
 
@@ skipping 121 matching lines @@
   // Invoked on the FILE thread to delete HTML5 databases.
   void ClearDatabasesOnFILEThread();
 
   // Callback when HTML5 file systems have been cleared.  Invokes
   // NotifyAndDeleteIfDone.
   void OnClearedFileSystems();
 
   // Invoked on the FILE thread to delete HTML5 file systems.
   void ClearFileSystemsOnFILEThread();
 
+  // Callback to respond to QuotaManager::GetOriginsModifiedSince.
+  void ProcessTemporaryQuotaModifiedInTimeframe(const std::set<GURL>&);
+
+  void DeleteOriginDataCallback(quota::QuotaStatusCode);
+
   // Callback when the appcache has been cleared. Invokes
   // NotifyAndDeleteIfDone.
   void OnClearedAppCache();
 
   // Invoked on the IO thread to delete from the AppCache.
   void ClearAppCacheOnIOThread();
 
   // Lower level helpers.
   void OnGotAppCacheInfo(int rv);
   void OnAppCacheDeleted(int rv);
@@ skipping 60 matching lines @@
   base::WaitableEventWatcher watcher_;
 
   // True if we're waiting for various data to be deleted.
   bool waiting_for_clear_databases_;
   bool waiting_for_clear_history_;
   bool waiting_for_clear_networking_history_;
   bool waiting_for_clear_cache_;
   bool waiting_for_clear_appcache_;
   bool waiting_for_clear_lso_data_;
   bool waiting_for_clear_gears_data_;
   bool waiting_for_clear_file_systems_;

[michaeln, 2011/07/21 23:49:15]

I was thinking that use of the QuotaManager could completely replace the removal
logic for databases, appcaches, and filesystems (for both from-time and
for-all-time removal); so the flags and methods related to dealing with each of
those individually those could be removed. So you'd have some new methods
like...

void ClearQuotaManagedDataOnIOThread();
void OnGotQuotaManagedOrigins(const std::set<GURL>&);
void OnDeletedQuotaManagedOrigin(quota::QuotaStatusCode);

And a bunch of appcache/filesystem/database specific methods and members
removed.

 
+  // Tracking how many origins need to be deleted.
+  int temporary_quota_origins_to_delete_count_;
+
   ObserverList<Observer> observer_list_;
 
   // Used if we need to clear history.
   CancelableRequestConsumer request_consumer_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowsingDataRemover);
 };
 
 #endif  // CHROME_BROWSER_BROWSING_DATA_REMOVER_H_