Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: test/mjsunit/object-define-property.js

Issue 7129017: Fix bug in Object.defineProperty where a growing lements dictionary was ignored. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 { enumerable : false, configurable : false }, 1038 { enumerable : false, configurable : false },
1039 { get: getter1, set: setter1, enumerable : false, configurable : false }); 1039 { get: getter1, set: setter1, enumerable : false, configurable : false });
1040 1040
1041 // redefine of set only property with generic descriptor 1041 // redefine of set only property with generic descriptor
1042 o = {}; 1042 o = {};
1043 Object.defineProperty(o, 'p', 1043 Object.defineProperty(o, 'p',
1044 { set : setter1, enumerable: true, configurable: true }); 1044 { set : setter1, enumerable: true, configurable: true });
1045 testDefineProperty(o, 'p', 1045 testDefineProperty(o, 'p',
1046 { enumerable : false, configurable : false }, 1046 { enumerable : false, configurable : false },
1047 { get: undefined, set: setter1, enumerable : false, configurable : false }); 1047 { get: undefined, set: setter1, enumerable : false, configurable : false });
1048
1049
1050 // Regression test: Ensure that growing dictionaries are not ignored.
1051 o = {};
1052 for (var i = 0; i < 1000; i++) {
1053 // Non-enumerable property forces dictionary mode.
1054 Object.defineProperty(o, i, {value: i, enumerable: false});
1055 }
1056 assertEquals(999, o[999]);
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698