Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: src/handles.h

Issue 7129017: Fix bug in Object.defineProperty where a growing lements dictionary was ignored. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/handles.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 // They might invoke garbage collection. The result is an handle to 166 // They might invoke garbage collection. The result is an handle to
167 // an object of expected type, or the handle is an error if running out 167 // an object of expected type, or the handle is an error if running out
168 // of space or encountering an internal error. 168 // of space or encountering an internal error.
169 169
170 void NormalizeProperties(Handle<JSObject> object, 170 void NormalizeProperties(Handle<JSObject> object,
171 PropertyNormalizationMode mode, 171 PropertyNormalizationMode mode,
172 int expected_additional_properties); 172 int expected_additional_properties);
173 void NormalizeElements(Handle<JSObject> object); 173 void NormalizeElements(Handle<JSObject> object);
174 void TransformToFastProperties(Handle<JSObject> object, 174 void TransformToFastProperties(Handle<JSObject> object,
175 int unused_property_fields); 175 int unused_property_fields);
176 void NumberDictionarySet(Handle<NumberDictionary> dictionary, 176 MUST_USE_RESULT Handle<NumberDictionary> NumberDictionarySet(
177 uint32_t index, 177 Handle<NumberDictionary> dictionary,
178 Handle<Object> value, 178 uint32_t index,
179 PropertyDetails details); 179 Handle<Object> value,
180 PropertyDetails details);
180 181
181 // Flattens a string. 182 // Flattens a string.
182 void FlattenString(Handle<String> str); 183 void FlattenString(Handle<String> str);
183 184
184 // Flattens a string and returns the underlying external or sequential 185 // Flattens a string and returns the underlying external or sequential
185 // string. 186 // string.
186 Handle<String> FlattenGetString(Handle<String> str); 187 Handle<String> FlattenGetString(Handle<String> str);
187 188
188 Handle<Object> SetProperty(Handle<JSReceiver> object, 189 Handle<Object> SetProperty(Handle<JSReceiver> object,
189 Handle<String> key, 190 Handle<String> key,
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 inline NoHandleAllocation(); 370 inline NoHandleAllocation();
370 inline ~NoHandleAllocation(); 371 inline ~NoHandleAllocation();
371 private: 372 private:
372 int level_; 373 int level_;
373 #endif 374 #endif
374 }; 375 };
375 376
376 } } // namespace v8::internal 377 } } // namespace v8::internal
377 378
378 #endif // V8_HANDLES_H_ 379 #endif // V8_HANDLES_H_
OLDNEW
« no previous file with comments | « no previous file | src/handles.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698