Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: src/handles.cc

Issue 7129017: Fix bug in Object.defineProperty where a growing lements dictionary was ignored. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/handles.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 221
222 222
223 void TransformToFastProperties(Handle<JSObject> object, 223 void TransformToFastProperties(Handle<JSObject> object,
224 int unused_property_fields) { 224 int unused_property_fields) {
225 CALL_HEAP_FUNCTION_VOID( 225 CALL_HEAP_FUNCTION_VOID(
226 object->GetIsolate(), 226 object->GetIsolate(),
227 object->TransformToFastProperties(unused_property_fields)); 227 object->TransformToFastProperties(unused_property_fields));
228 } 228 }
229 229
230 230
231 void NumberDictionarySet(Handle<NumberDictionary> dictionary, 231 Handle<NumberDictionary> NumberDictionarySet(
232 uint32_t index, 232 Handle<NumberDictionary> dictionary,
233 Handle<Object> value, 233 uint32_t index,
234 PropertyDetails details) { 234 Handle<Object> value,
235 CALL_HEAP_FUNCTION_VOID(dictionary->GetIsolate(), 235 PropertyDetails details) {
236 dictionary->Set(index, *value, details)); 236 CALL_HEAP_FUNCTION(dictionary->GetIsolate(),
237 dictionary->Set(index, *value, details),
238 NumberDictionary);
237 } 239 }
238 240
239 241
240 void FlattenString(Handle<String> string) { 242 void FlattenString(Handle<String> string) {
241 CALL_HEAP_FUNCTION_VOID(string->GetIsolate(), string->TryFlatten()); 243 CALL_HEAP_FUNCTION_VOID(string->GetIsolate(), string->TryFlatten());
242 } 244 }
243 245
244 246
245 Handle<String> FlattenGetString(Handle<String> string) { 247 Handle<String> FlattenGetString(Handle<String> string) {
246 CALL_HEAP_FUNCTION(string->GetIsolate(), string->TryFlatten(), String); 248 CALL_HEAP_FUNCTION(string->GetIsolate(), string->TryFlatten(), String);
(...skipping 720 matching lines...) Expand 10 before | Expand all | Expand 10 after
967 969
968 bool CompileOptimized(Handle<JSFunction> function, 970 bool CompileOptimized(Handle<JSFunction> function,
969 int osr_ast_id, 971 int osr_ast_id,
970 ClearExceptionFlag flag) { 972 ClearExceptionFlag flag) {
971 CompilationInfo info(function); 973 CompilationInfo info(function);
972 info.SetOptimizing(osr_ast_id); 974 info.SetOptimizing(osr_ast_id);
973 return CompileLazyHelper(&info, flag); 975 return CompileLazyHelper(&info, flag);
974 } 976 }
975 977
976 } } // namespace v8::internal 978 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/handles.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698