Fix ProfileManagerTest.CreateProfileAsync failures on cros.

Fix ProfileManagerTest.CreateProfileAsync failures on cros.

Per Alexey's debugging, the problem was because NotificationUIManager was being deleted after the testing PrefsService has gone away.  So when the TestingBrowserProcess is told that PrefsService is going away, destruct the NotificationUIManager then.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88362

[Scott Hess - ex-Googler, 2011-06-08 16:43:43]

LGTM.

http://codereview.chromium.org/7129009/diff/5001/chrome/test/testing_browser_...
File chrome/test/testing_browser_process.cc (right):

http://codereview.chromium.org/7129009/diff/5001/chrome/test/testing_browser_...
chrome/test/testing_browser_process.cc:241: notification_ui_manager_.reset(); 
// Used local_state_.
Wouldn't this (potentially) apply in any case where local_state != local_state_?

[jam, 2011-06-08 16:48:27]

http://codereview.chromium.org/7129009/diff/5001/chrome/test/testing_browser_...
File chrome/test/testing_browser_process.cc (right):

http://codereview.chromium.org/7129009/diff/5001/chrome/test/testing_browser_...
chrome/test/testing_browser_process.cc:241: notification_ui_manager_.reset(); 
// Used local_state_.
On 2011/06/08 16:43:43, shess wrote:
> Wouldn't this (potentially) apply in any case where local_state !=
local_state_?

I thought about trying to add fancier checks initially.  But if someone changes
the PrefsService, which doesn't happen now, I would guess that other stuff
breaks as is.  So I decided to do the minimal fix.  Note that the tests now are
into varieties: create (one) prefsservice or not.  The prefsservice must have
been set before NotificationUIManager is created, since it uses it in its
construction.  So if notification_ui_manager_ is set, we know that local_state_
must have been set.