Issue 7129002: Fix bug 1433: clear the global thread table when an isolate is disposed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7129002: Fix bug 1433: clear the global thread table when an isolate is disposed. (Closed)

Created:
9 years, 6 months ago by Vitaly Repeshko

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix bug 1433: clear the global thread table when an isolate is disposed. R=ager@chromium.org BUG=v8:1433 TEST=test-lockers/Regress1433 Committed: http://code.google.com/p/v8/source/detail?r=8209

Patch Set 1 #

Total comments: 4

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -0 lines)			Patch
M	src/isolate.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/isolate.cc	View	3 chunks	+15 lines, -0 lines	0 comments	Download
M	test/cctest/test-lockers.cc	View	1 chunk	+20 lines, -0 lines	4 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM! http://codereview.chromium.org/7129002/diff/1/test/cctest/test-lockers.cc File test/cctest/test-lockers.cc (right): http://codereview.chromium.org/7129002/diff/1/test/cctest/test-lockers.cc#newcode616 test/cctest/test-lockers.cc:616: v8::Locker l(isolate); l -> lock? http://codereview.chromium.org/7129002/diff/1/test/cctest/test-lockers.cc#newcode617 test/cctest/test-lockers.cc:617: v8::Isolate::Scope ...

9 years, 6 months ago (2011-06-07 18:28:18 UTC) #2

Vitaly Repeshko

9 years, 6 months ago (2011-06-07 18:32:53 UTC) #3

Thanks for quick review!

http://codereview.chromium.org/7129002/diff/1/test/cctest/test-lockers.cc
File test/cctest/test-lockers.cc (right):

http://codereview.chromium.org/7129002/diff/1/test/cctest/test-lockers.cc#new...
test/cctest/test-lockers.cc:616: v8::Locker l(isolate);
On 2011/06/07 18:28:18, Mads Ager wrote:
> l -> lock?

Done.

http://codereview.chromium.org/7129002/diff/1/test/cctest/test-lockers.cc#new...
test/cctest/test-lockers.cc:617: v8::Isolate::Scope iscope(isolate);
On 2011/06/07 18:28:18, Mads Ager wrote:
> iscope -> isolate_scope
> 
> to match the other naming?

Done.

Expand Messages | Collapse Messages