Issue 7125004: Support named months for Autofill implicit learning

Issue 7125004: Support named months for Autofill implicit learning (Closed)

Created:
9 years, 6 months ago by Ilya Sherman

Modified:
9 years, 6 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, GeorgeY, Paweł Hajdan Jr., Ilya Sherman, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Support named months for Autofill implicit learning BUG=64733 TEST=unit_tests --gtest_filter=CreditCardTest.SetInfoExpirationMonth Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88296

Patch Set 1 #

Total comments: 4

Patch Set 2 : From one, two #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -11 lines)			Patch
	M	chrome/browser/autofill/credit_card.cc	View	1	4 chunks	+62 lines, -11 lines	0 comments	Download
	M	chrome/browser/autofill/credit_card_unittest.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dhollowa

http://codereview.chromium.org/7125004/diff/1/chrome/browser/autofill/credit_card.cc File chrome/browser/autofill/credit_card.cc (right): http://codereview.chromium.org/7125004/diff/1/chrome/browser/autofill/credit_card.cc#newcode125 chrome/browser/autofill/credit_card.cc:125: bool ConvertDate(const string16& date, bool is_month, int* num) { ...

9 years, 6 months ago (2011-06-07 16:33:00 UTC) #2

Ilya Sherman

9 years, 6 months ago (2011-06-08 00:10:12 UTC) #3

LGTM.  Thanks.

Expand Messages | Collapse Messages