Issue 7124001: [cleanup] Use Delegate method to control context menu and eliminate HtmlDialogWithoutContextMenuView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7124001: [cleanup] Use Delegate method to control context menu and eliminate HtmlDialogWithoutContextMenuView (Closed)

Created:
9 years, 6 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use Delegate method to control context menu and eliminate HtmlDialogWithoutContextMenuView BUG=none TEST=none. no functional change. all test should still pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88347

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -78 lines)			Patch
M	chrome/browser/chromeos/choose_mobile_network_dialog.h	View		1 chunk	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/choose_mobile_network_dialog.cc	View	1	3 chunks	+8 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_html_dialog.h	View		1 chunk	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_html_dialog.cc	View		3 chunks	+7 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/sim_dialog_delegate.h	View		1 chunk	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/sim_dialog_delegate.cc	View		3 chunks	+8 lines, -17 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM

Sorry, forgot to review yesterday.