Merge 88174 - 2011-06-06 Shishir Agrawal <shishir@chromium.org>

Tools/ChangeLog

+2011-06-06  Shishir Agrawal  <shishir@chromium.org>
+
+        Reviewed by Tony Gentilcore.
+
+        Add a "prerender" state for page visibility.
+        https://bugs.webkit.org/show_bug.cgi?id=62062
+
+        * DumpRenderTree/chromium/LayoutTestController.cpp:
+        (LayoutTestController::setPageVisibility):
+
+2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
+
+        [Qt] Implement download feature for QtTestBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=61865
+
+        Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
+
+        * QtTestBrowser/launcherwindow.cpp:
+        (LauncherWindow::LauncherWindow):
+        * QtTestBrowser/launcherwindow.h:
+
+2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
+
+        Reviewed by Csaba Osztrogonác.
+
+        [Qt] Implement download feature for QtTestBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=61865
+
+        * QtTestBrowser/launcherwindow.cpp:
+        (LauncherWindow::LauncherWindow):
+        (LauncherWindow::downloadRequest):
+        (LauncherWindow::fileDownloadFinished):
+        * QtTestBrowser/launcherwindow.h:
+
+2011-06-04  Dominic Cooney  <dominicc@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Make DumpRenderTree initialize window.internals.
+        https://bugs.webkit.org/show_bug.cgi?id=61076
+
+        * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
+        * DumpRenderTree/win/FrameLoadDelegate.cpp:
+        (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
+
+2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
+
+        Reviewed by Kent Tamura.
+
+        Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
+        https://bugs.webkit.org/show_bug.cgi?id=61628
+
+        * Scripts/build-webkit:
+
+2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
+
+        Reviewed by Kent Tamura.
+
+        Add ENABLE(CSS_REGIONS) guard for CSS Regions support
+        https://bugs.webkit.org/show_bug.cgi?id=61631
+
+        * Scripts/build-webkit:
+
+2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Unreviewed. Fix the GTK+ build.
+
+        * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
+
+2011-06-05  Alexey Proskuryakov  <ap@apple.com>
+
+        Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
+        works properly).
+
+        * Scripts/webkitpy/common/config/committers.py:
+
+2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
+
+        [wx] Unreviewed build fix. Update git branch build dir handling to match what other
+        WebKit scripts expect, so other scripts work properly with wx.
+
+        * waf/build/build_utils.py:
+        * waf/build/settings.py:
+
+2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
+
+        [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
+        to build on Mac.
+
+        * waf/build/settings.py:
+        * wx/install-unix-extras:
+
+2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
+
+        [wx] Unreviewed build fixes for recent trunk changes.
+
+        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
+        (LayoutTestController::setTextDirection):
+        * waf/build/settings.py:
+
+2011-06-04  Martin Robinson  <mrobinson@igalia.com>
+
+        Fix the GTK+ build.
+
+        * GNUmakefile.am: Add some missing newline escape.
+
+2011-06-03  Martin Robinson  <mrobinson@igalia.com>
+
+        Try to fix the GTK+ bulid.
+
+        * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
+        source list.
+
+2011-06-03  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        nrwt: should skip chromium test expectation overrides on upstream bots
+        https://bugs.webkit.org/show_bug.cgi?id=61888
+
+        * Scripts/webkitpy/layout_tests/port/chromium.py:
+        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
+
+2011-06-03  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Ojan Vafai.
+
+        new-run-webkit-tests: minor logging, code cleanup
+        https://bugs.webkit.org/show_bug.cgi?id=62055
+
+        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
+        * Scripts/webkitpy/layout_tests/layout_package/worker.py:
+
+2011-06-03  Martin Robinson  <mrobinson@igalia.com>
+
+        Try to fix the build failure on the GTK+ 32-bit Release bot.
+
+        * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
+
+2011-05-31  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Ryosuke Niwa.
+
+        [GTK] Support smart replace for the pasteboard
+        https://bugs.webkit.org/show_bug.cgi?id=61734
+
+        Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
+        This is required to produce consistent test results.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
+        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+        (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
+        methods which calls into DumpRenderTreeSupportGtk.
+
+2011-06-03  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Teach Gtk build about window.internals
+        https://bugs.webkit.org/show_bug.cgi?id=61071
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (webViewWindowObjectCleared): Inject the new internals object when the
+        window object clears.
+        * GNUmakefile.am: Add new source files and includes necessary for window.internals.
+        Also do a little bit of cleanup.
+
+2011-06-03  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        Worker may not be stopped after LT.
+        https://bugs.webkit.org/show_bug.cgi?id=61847
+
+        Re-submit a variant of the first fix for this bug. It's possible
+        that actually calling cleanup() in the worker threads was taking
+        too long and we triggered the assertions in the manager thread.
+
+        I've bumped up the timeout in the manager and added better
+        diagnostics. I also cleaned up the cleanup() code a bit because
+        there was some unnecessary if-checks.
+
+        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
+        * Scripts/webkitpy/layout_tests/layout_package/worker.py:
+
+2011-06-03  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        nrwt: fix duplicate logging regression
+        https://bugs.webkit.org/show_bug.cgi?id=61981
+
+        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
+
+2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Modified addTouchPoint to correctly re-use touchPoint id values starting
+        from the lowest not-un-use touchPoint id as is done by the embedder
+        APIs. (Fixes BUGCR36415)
+
+        https://bugs.webkit.org/show_bug.cgi?id=62016
+
+        * DumpRenderTree/chromium/EventSender.cpp:
+        (EventSender::addTouchPoint):
+
+2011-06-03  Cary Clark  <caryclark@google.com>
+
+        Reviewed by Eric Seidel.
+
+        Draw DRT scroll bar thumb with CG when WebKit renders with Skia
+        https://bugs.webkit.org/show_bug.cgi?id=61534
+
+        Skia on Mac uses Skia to render WebKit, and CG
+        to render UI elements. The CG elements need a
+        transcribed graphics context that preserves the
+        canvas matrix, and the canvas clip.
+
+        The SkiaBitLocker utility class sets up a CGContext
+        from the SkCanvas, locks the bitmap's bits, and
+        releases the lock when the class goes out of scope.
+
+        The SkiaBitLocker implementation is described by
+        this patch:
+        http://codereview.chromium.org/7031006/
+
+        When WebKit uses Skia for rendering, the WebCanvas
+        is an SkCanvas. Create an equivalent CGContext to
+        draw the scrollbar thumb.
+
+        As the Chrome Mac port does not yet use Skia, this
+        patch has no effect and requires no tests.
+
+        * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
+        (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
+
+2011-06-03  Andras Becsi  <abecsi@webkit.org>
+
+        Unreviewed build fix.
+
+        Fix typo.
+
+        * Scripts/old-run-webkit-tests:
+
+2011-06-03  Andras Becsi  <abecsi@webkit.org>
+
+        Reviewed by Csaba Osztrogonác.
+
+        Print error message when there is no httpd present on the system
+        https://bugs.webkit.org/show_bug.cgi?id=61939
+
+        * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
+        * Scripts/webkitperl/httpd.pm:
+
+2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
+        https://bugs.webkit.org/show_bug.cgi?id=61533
+
+        Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
+
+        * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
+        (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
+        * DumpRenderTree/chromium/DRTDevToolsAgent.h:
+        * DumpRenderTree/chromium/LayoutTestController.cpp:
+        (LayoutTestController::LayoutTestController):
+        (LayoutTestController::setJavaScriptProfilingEnabled):
+        * DumpRenderTree/chromium/LayoutTestController.h:
+        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
+        (LayoutTestController::setJavaScriptProfilingEnabled):
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+        (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
+        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
+
+2011-06-02  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        NRWT needs a way to log to a file without including backspaces without needing --verbose
+        https://bugs.webkit.org/show_bug.cgi?id=60328
+
+        This change modifies NRWT so that if it can tell if it is
+        writing to a terminal, it will overwrite any messages printed
+        in the 'one-line-progress' and 'updates' print options, and if
+        not (or if --verbose was specified) the messages will be printed
+        without backspaces.
+
+        If the overwriting updates are disabled, one-line-progress will
+        only print every 10 seconds instead of on every update. This
+        ensures that we still get updates once in a while while the
+        tests are running, even if we're not in --verbose mode. Note
+        that one-line-progress will now still be printed in --verbose,
+        since it's useful as long as you're not flooded with the
+        updates.
+
+        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
+        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
+        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
+
+2011-06-02  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Gustavo Noronha Silva.
+
+        [GTK] autogen.sh is run twice for each buld on the bots
+        https://bugs.webkit.org/show_bug.cgi?id=61951
+
+        * Scripts/webkitdirs.pm: Only check the previous autotools arguments
+        for the WebKit project. This prevents build-jsc runs from forcing subsequent
+        build-webkit runs to re-rerun autogen.sh.
+
+2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r87946.
+        http://trac.webkit.org/changeset/87946
+        https://bugs.webkit.org/show_bug.cgi?id=61965
+
+        Cause NRWT to break (Requested by abarth|gardener on #webkit).
+
+        * Scripts/webkitpy/layout_tests/layout_package/worker.py:
+
+2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Add build logistics and plumbing for window.internals object.
+        https://bugs.webkit.org/show_bug.cgi?id=60313
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::bindJSObjectsToWindow): Added injection code.
+        * DumpRenderTree/mac/FrameLoadDelegate.mm:
+        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
+
+2011-06-02  Hao Zheng  <zhenghao@chromium.org>
+
+        Reviewed by Dirk Pranke.
+
+        Call cleanup() explicitly at the end of worker.run().
+        https://bugs.webkit.org/show_bug.cgi?id=61847
+
+        * Scripts/webkitpy/layout_tests/layout_package/worker.py:
+
+2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Unreviewed, rolling out r87926.
+        http://trac.webkit.org/changeset/87926
+        https://bugs.webkit.org/show_bug.cgi?id=60313
+
+        Fails to find WebCoreTestSupport.dylib on bots.
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::bindJSObjectsToWindow):
+        * DumpRenderTree/mac/FrameLoadDelegate.mm:
+        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
+
+2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Add build logistics and plumbing for window.internals object.
+        https://bugs.webkit.org/show_bug.cgi?id=60313
+
+        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
+        * DumpRenderTree/chromium/TestShell.cpp:
+        (TestShell::bindJSObjectsToWindow): Added injection code.
+        * DumpRenderTree/mac/FrameLoadDelegate.mm:
+        (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
+
+2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Reviewed by Eric Seidel.
+
+        Adjust efl coding style to more efl directories
+        https://bugs.webkit.org/show_bug.cgi?id=61903
+
+        * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
+
+2011-06-01  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        old-run-webkit-tests: add support for audio files
+        https://bugs.webkit.org/show_bug.cgi?id=57992
+
+        * Scripts/old-run-webkit-tests:
+
+2011-06-01  Jochen Eisinger  <jochen@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
+        https://bugs.webkit.org/show_bug.cgi?id=34314
+
+        * DumpRenderTree/DumpRenderTree.gypi:
+        * DumpRenderTree/chromium/LayoutTestController.cpp:
+        (LayoutTestController::LayoutTestController):
+        (LayoutTestController::setImagesAllowed):
+        (LayoutTestController::setStorageAllowed):
+        * DumpRenderTree/chromium/LayoutTestController.h:
+        * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
+        (WebPermissions::WebPermissions):
+        (WebPermissions::~WebPermissions):
+        (WebPermissions::allowImages):
+        (WebPermissions::allowStorage):
+        (WebPermissions::setImagesAllowed):
+        (WebPermissions::setStorageAllowed):
+        (WebPermissions::reset):
+        * DumpRenderTree/chromium/WebPermissions.h:
+
+2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
+
+        Reviewed by Tony Chang.
+
+        Test plugin should support event logging on the windows port.
+        https://bugs.webkit.org/show_bug.cgi?id=61721
+
+        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
+        (handleEventWin): Well, handle them.
+
+2011-06-01  Daniel Cheng  <dcheng@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        [chromium] Use correct file name for dragging out images.
+        https://bugs.webkit.org/show_bug.cgi?id=24887
+
+        * DumpRenderTree/chromium/EventSender.cpp:
+        (EventSender::EventSender):
+        (EventSender::dumpFilenameBeingDragged):
+        * DumpRenderTree/chromium/EventSender.h:
+
+2011-06-01  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Tony Chang.
+
+        nrwt: make webaudio work w/o content-length header
+        https://bugs.webkit.org/show_bug.cgi?id=61819
+
+        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
+        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
+        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
+        * Scripts/webkitpy/layout_tests/port/webkit.py:
+
+2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
+
+        Reviewed by Andreas Kling.
+
+        [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=61802
+
+        Add command line parameter and menu item to MiniBrowser application 
+        enabling use of QGLWidget for browser viewport.
+
+        * MiniBrowser/qt/BrowserWindow.cpp:
+        (BrowserWindow::BrowserWindow):
+        (BrowserWindow::toggleGLViewport):
+        * MiniBrowser/qt/BrowserWindow.h:
+        * MiniBrowser/qt/MiniBrowserApplication.cpp:
+        (MiniBrowserApplication::handleUserOptions):
+        * MiniBrowser/qt/MiniBrowserApplication.h:
+        (WindowOptions::WindowOptions):
+
+2011-06-01  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Xan Lopez.
+
+        Print out autogen arguments when they differ from the last set, to help
+        with debugging build issues.
+
+        * Scripts/webkitdirs.pm: Print out previous and current build arguments
+        when they differ.
+
+2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Reviewed by Martin Robinson.
+
+        [GTK] run-launcher should run MiniBrowser in WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=61858
+
+        * Scripts/run-launcher: Check whether -2 command line option has
+        been passed and run MiniBrowser instead of GtkLauncher.
+
+2011-05-31  Hao Zheng  <zhenghao@chromium.org>
+
+        Reviewed by Dirk Pranke.
+
+        Fix exception in verbose printing mode.
+        https://bugs.webkit.org/show_bug.cgi?id=61723
+
+        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
+
 2011-05-31  Yong Li  <yoli@rim.com>
 
         Reviewed by Eric Seidel.
 
         https://bugs.webkit.org/show_bug.cgi?id=54807
         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
@@ skipping 13836 matching lines @@
         
         r78737 rolled over ChangeLogs, and webkit-patch complains when landing
         patches such as this one that are the first to add an entry to the
         ChangeLog (since they don't see a second date line to know where the
         entry ends).
 
         * Scripts/webkitpy/common/checkout/changelog.py:
         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
 
 == Rolled over to ChangeLog-2011-02-16 ==