Merge 88174 - 2011-06-06 Shishir Agrawal <shishir@chromium.org>

Source/WebKit/chromium/ChangeLog

+2011-06-06  Shishir Agrawal  <shishir@chromium.org>
+
+        Reviewed by Tony Gentilcore.
+
+        Add a "prerender" state for page visibility.
+        https://bugs.webkit.org/show_bug.cgi?id=62062
+
+        * public/WebPageVisibilityState.h:
+        * src/AssertMatchingEnums.cpp:
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::setVisibilityState):
+
+2011-06-06  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        webkit/glue/webmediaplayer_impl.cc deletes an object of type
+        WebVideoFrame, which means this patch fixes a real bug, not just
+        a theoretical one.
+
+        [chromium] Give WebVideoFrame a virtual destructor
+        https://bugs.webkit.org/show_bug.cgi?id=61742
+
+        * public/WebVideoFrame.h:
+        (WebKit::WebVideoFrame::~WebVideoFrame):
+
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make ResourceHandleInternal's destructor virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62073
+
+        This is _not_ to fix a real bug, just to make clang's
+        -Wdelete-non-virtual-dtor happy. As discussed at
+        http://codereview.chromium.org/7094005/, we prefer making leaf class
+        destructors virtual over making the leaf classes final.
+
+        * src/ResourceHandle.cpp:
+        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
+
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make ChromePrintContext's destructor virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62076
+
+        Since WebFrameImpl's m_printContext is a OnwPtr<ChromePrintContext>
+        that is dynamically set to either a ChromePrintContext or a
+        ChromePluginPrintContext, this fixes an actual bug.
+
+        * src/WebFrameImpl.cpp:
+        (WebKit::ChromePrintContext::~ChromePrintContext):
+        (WebKit::ChromePluginPrintContext::~ChromePluginPrintContext):
+
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make WebTextCheckingCompletionImpl's destructor virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62074
+
+        This is _not_ to fix a real bug, just to make clang's
+        -Wdelete-non-virtual-dtor happy. As discussed at
+        http://codereview.chromium.org/7094005/, we prefer making leaf class
+        destructors virtual over making the leaf classes final.
+
+        * src/WebTextCheckingCompletionImpl.h:
+        (WebKit::WebTextCheckingCompletionImpl::~WebTextCheckingCompletionImpl):
+
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make PlatformMessagePortChannel's destructor virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62072
+
+        This is _not_ to fix a real bug, just to make clang's
+        -Wdelete-non-virtual-dtor happy. As discussed at
+        http://codereview.chromium.org/7094005/, we prefer making leaf class
+        destructors virtual over making the leaf classes final.
+
+        * src/PlatformMessagePortChannel.h:
+
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Give VoidCallbackClient a virtual destructor
+        https://bugs.webkit.org/show_bug.cgi?id=62067
+
+        This is _not_ to fix a real bug, just to make clang's
+        -Wdelete-non-virtual-dtor happy. As discussed at
+        http://codereview.chromium.org/7094005/, we prefer making leaf class
+        destructors virtual over making the leaf classes final.
+
+        * src/NotificationPresenterImpl.cpp:
+        (WebKit::VoidCallbackClient::~VoidCallbackClient):
+
+2011-06-04  Nico Weber  <thakis@chromium.org>
+
+        Reviewed by James Robinson.
+
+        [chromium] Make WebFrameImpl destructor virtual
+        https://bugs.webkit.org/show_bug.cgi?id=62065
+
+        This is _not_ to fix a real bug, just to make clang's
+        -Wdelete-non-virtual-dtor happy. As discussed at
+        http://codereview.chromium.org/7094005/, we prefer making leaf class
+        destructors virtual over making the leaf classes final.
+
+        * src/WebFrameImpl.h:
+
+2011-06-03  Philippe Beauchamp  <philippe.beauchamp@gmail.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        Add the feature "Add as search engine..." in a search text field context menu for chromium
+        https://bugs.webkit.org/show_bug.cgi?id=47980
+
+        * public/WebContextMenuData.h:
+        * public/WebSearchableFormData.h:
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+        * src/WebSearchableFormData.cpp:
+        (WebKit::WebSearchableFormData::WebSearchableFormData):
+
+2011-06-03  Naoki Takano  <takano.naoki@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        [Chromium] Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.
+        https://bugs.webkit.org/show_bug.cgi?id=61260
+        http://code.google.com/p/chromium/issues/detail?id=12721
+
+        * public/WebMenuItemInfo.h: Add toolTip.
+        * public/WebViewClient.h: Remove setToolTipText().
+        * public/WebWidgetClient.h: Add setTooTipText().
+        (WebKit::WebWidgetClient::setToolTipText):
+        * src/ExternalPopupMenu.cpp:
+        (WebKit::ExternalPopupMenu::getPopupMenuInfo): Add popupItem.toolTip set.
+        * src/WebPopupMenuImpl.cpp:
+        (WebKit::WebPopupMenuImpl::MouseMove): Call setToolTipText().
+
+2011-06-03  Hans Wennborg  <hans@chromium.org>
+
+        Reviewed by Steve Block.
+
+        IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
+        https://bugs.webkit.org/show_bug.cgi?id=62009
+
+        Don't use INT64_MAX, use the various encodeMaxKey() functions instead.
+
+        * tests/IDBLevelDBCodingTest.cpp:
+        (IDBLevelDBCoding::TEST):
+
+2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
+        https://bugs.webkit.org/show_bug.cgi?id=61533
+
+        Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
+
+        * public/WebDevToolsAgent.h:
+        * src/WebDevToolsAgentImpl.cpp:
+        (WebKit::WebDevToolsAgentImpl::setJavaScriptProfilingEnabled):
+        * src/WebDevToolsAgentImpl.h:
+
+2011-06-02  Yury Semikhatsky  <yurys@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: add an option for automatically attaching to new workers
+        https://bugs.webkit.org/show_bug.cgi?id=61930
+
+        Notification about worker context termination are now sent to the inspector.
+
+        * src/WebWorkerClientImpl.cpp:
+        (WebKit::WebWorkerClientImpl::terminateWorkerContext):
+        (WebKit::WebWorkerClientImpl::disconnectFromInspector):
+        (WebKit::WebWorkerClientImpl::workerContextDestroyed):
+
+2011-06-02  Aaron Colwell  <acolwell@chromium.org>
+
+        Reviewed by David Levin.
+
+        Add mediaTimeForTimeValue() implementation.
+        https://bugs.webkit.org/show_bug.cgi?id=61555
+
+        * public/WebMediaPlayer.h:
+        * src/WebMediaPlayerClientImpl.cpp:
+        (WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
+        * src/WebMediaPlayerClientImpl.h:
+
+2011-06-02  Jay Civelli  <jcivelli@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Adding MHTML generation support to MHTMLArchive.
+        https://bugs.webkit.org/show_bug.cgi?id=7169
+
+        * public/WebPageSerializer.h:
+        * src/WebPageSerializer.cpp:
+        (WebKit::WebPageSerializer::serializeToMHTML):
+
+2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Add build logistics and plumbing for window.internals object.
+        https://bugs.webkit.org/show_bug.cgi?id=60313
+
+        * WebKit.gyp: Added linking new webkit_test_support library.
+        * public/WebTestingSupport.h: Added.
+        * src/WebTestingSupport.cpp: Added.
+
+2011-06-02  Aaron Colwell  <acolwell@chromium.org>
+
+        Reviewed by David Levin.
+
+        Update chromium version
+        https://bugs.webkit.org/show_bug.cgi?id=61555
+
+        * DEPS:
+
+2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r87920.
+        http://trac.webkit.org/changeset/87920
+        https://bugs.webkit.org/show_bug.cgi?id=61943
+
+        This patch does not build in Win Builder (dbg)(shared)
+        downstream (Requested by abarth|gardener on #webkit).
+
+        * tests/PopupMenuTest.cpp:
+        (WebKit::TestPopupMenuClient::TestPopupMenuClient):
+        (WebKit::TestPopupMenuClient::valueChanged):
+        (WebKit::TestPopupMenuClient::itemIsEnabled):
+        (WebKit::SelectPopupMenuTest::TearDown):
+        * tests/data/popup/select_event.html: Removed.
+        * tests/data/popup/select_event_remove_on_change.html: Removed.
+        * tests/data/popup/select_event_remove_on_click.html: Removed.
+
+2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Unreviewed, rolling out r87926.
+        http://trac.webkit.org/changeset/87926
+        https://bugs.webkit.org/show_bug.cgi?id=60313
+
+        Fails to find WebCoreTestSupport.dylib on bots.
+
+        * WebKit.gyp:
+        * public/WebTestingSupport.h: Removed.
+        * src/WebTestingSupport.cpp: Removed.
+
+2011-06-02  Aaron Colwell  <acolwell@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Bring gyp_webkit up to date with changes made to
+        gyp_chromium so chromium_rev can be advanced past
+        revision 87140.
+        https://bugs.webkit.org/show_bug.cgi?id=61881
+
+        * gyp_webkit:
+
+2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        Add build logistics and plumbing for window.internals object.
+        https://bugs.webkit.org/show_bug.cgi?id=60313
+
+        * WebKit.gyp: Added linking new webkit_test_support library.
+        * public/WebTestingSupport.h: Added.
+        * src/WebTestingSupport.cpp: Added.
+
+2011-06-02  Naoki Takano  <takano.naoki@gmail.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Click event is not fired for a menulist <select>
+        https://bugs.webkit.org/show_bug.cgi?id=60563
+
+        * tests/PopupMenuTest.cpp:
+        (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node.
+        (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList.
+        (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not.
+        (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item.
+        (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event.
+        (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL.
+        (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call.
+        (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL().
+        (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests().
+        (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string.
+        (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
+        * tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
+        * tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
+        * tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
+
+2011-06-01  Adrienne Walker  <enne@google.com>
+
+        Reviewed by James Robinson.
+
+        [chromium] Fix syncing of removed mask and replica layers
+        https://bugs.webkit.org/show_bug.cgi?id=61895
+
+        * tests/TreeSynchronizerTest.cpp:
+        (WebCore::TEST):
+
+2011-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r87788.
+        http://trac.webkit.org/changeset/87788
+        https://bugs.webkit.org/show_bug.cgi?id=61856
+
+        breaks windows chromium canary (Requested by jknotten on
+        #webkit).
+
+        * public/WebPageSerializer.h:
+        * src/WebPageSerializer.cpp:
+
+2011-06-01  Jay Civelli  <jcivelli@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Adding MHTML generation support to MHTMLArchive.
+        https://bugs.webkit.org/show_bug.cgi?id=7169
+
+        * public/WebPageSerializer.h:
+        * src/WebPageSerializer.cpp:
+        (WebKit::WebPageSerializer::serializeToMHTML):
+
+2011-06-01  Mikhail Naganov  <mnaganov@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
+        https://bugs.webkit.org/show_bug.cgi?id=61803
+
+        * WebKit.gyp:
+        * scripts/generate_devtools_zip.py:
+
+2011-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r87781.
+        http://trac.webkit.org/changeset/87781
+        https://bugs.webkit.org/show_bug.cgi?id=61842
+
+        breaks chromium linux release (Requested by mnaganov on
+        #webkit).
+
+        * WebKit.gyp:
+        * scripts/generate_devtools_zip.py:
+
+2011-05-31  Mikhail Naganov  <mnaganov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
+        https://bugs.webkit.org/show_bug.cgi?id=61803
+
+        * WebKit.gyp:
+        * scripts/generate_devtools_zip.py:
+
 2011-05-31  Kinuko Yasuda  <kinuko@chromium.org>
 
         Reviewed by Kent Tamura.
 
         [Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
         https://bugs.webkit.org/show_bug.cgi?id=61823
 
         Fixed assertion on errorCallback parameter.
 
         Test: storage/quotainfo-no-callbacks.html
@@ skipping 6633 matching lines @@
         https://bugs.webkit.org/show_bug.cgi?id=53728
 
         * src/IDBCallbacksProxy.cpp:
         (WebCore::IDBCallbacksProxy::onBlocked):
         * src/IDBCallbacksProxy.h:
         * src/WebIDBCallbacksImpl.cpp:
         (WebCore::WebIDBCallbacksImpl::onBlocked):
         * src/WebIDBCallbacksImpl.h:
 
 == Rolled over to ChangeLog-2011-02-16 ==