Introduced additional spellcheck related histogram.

Introduced additional spellcheck related histograms.

This change added:
- "SpellCheck.SuggestionHitRatio" (percentage)
- "SpellCheck.SuggestionHitRatio" (boolean)

TEST=manual
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88309

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88815

[gmorrita, 2011-06-07 06:45:37]

Hi Bono-san, could you take a look at this when you have time?
I added two additional UMA histograms for spell checking.

[Hironori Bono, 2011-06-08 03:04:52]

LGTM.
Thank you for adding them.

Regards,

Hironori Bono

[commit-bot: I haz the power, 2011-06-08 04:15:10]

Presubmit check for 7121006-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/renderer_host/render_view_host.cc

Presubmit checks took 1.5s to calculate.

[gmorrita, 2011-06-08 04:22:20]

Oops. I totally missed it...

[gmorrita, 2011-06-08 04:25:02]

Darin, could you take a look at this small change on render_view_host.cc?
This just added a histogram count-up.

[gmorrita, 2011-06-08 08:36:55]

Landed with TBR=darin, assuming the change is small enough.

[gmorrita, 2011-06-09 02:54:21]

Because the original patch was reverted at r88456, I'm retying with addressing
the problem.
Brett, could you give a quick look for render_view_context_menu.cc change?
It just adds a histogram counting.

[brettw, 2011-06-12 13:02:59]

LGTM

http://codereview.chromium.org/7121006/diff/5002/chrome/browser/spellcheck_ho...
File chrome/browser/spellcheck_host.h (right):

http://codereview.chromium.org/7121006/diff/5002/chrome/browser/spellcheck_ho...
chrome/browser/spellcheck_host.h:92: // attempt to be uploaded via UMA
What is "delta" for? The comment should say this.

Also: Comments should end in periods.

http://codereview.chromium.org/7121006/diff/5002/chrome/browser/spellcheck_ho...
File chrome/browser/spellcheck_host_impl.h (right):

http://codereview.chromium.org/7121006/diff/5002/chrome/browser/spellcheck_ho...
chrome/browser/spellcheck_host_impl.h:165: int suggestion_count_;
How about suggestion_show_count_? Just suggestion_count_ makes me think this is
the number of suggestions in a menu currently being showed or something.

[gmorrita, 2011-06-13 05:43:32]

Brett, thank you for taking a look!
I'll address your points before landing.

[commit-bot: I haz the power, 2011-06-13 07:49:20]

Try job failure for 7121006-6005 on win for step pyauto_functional_tests:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2011-06-13 08:55:07]

Try job failure for 7121006-6005 on win for step pyauto_functional_tests:
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[gmorrita, 2011-06-13 08:58:08]

I gave to rely a commit-bot and committed this manually.

[gmorrita, 2011-06-13 08:58:42]

Oops. I gave "up" to ...