Issue 7120005: Simplify Autofill Scanner semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7120005: Simplify Autofill Scanner semantics (Closed)

Created:
9 years, 6 months ago by Ilya Sherman

Modified:
9 years, 6 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, GeorgeY, Ilya Sherman, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Simplify Autofill Scanner semantics SaveCursor() no longer provides stack semantics. Instead, it only saves the most recent cursor position. Clients who want to save multiple cursors can now capture the result of SaveCursor() and later explicitly RewindTo() saved positions. BUG=85142 TEST=unit_tests --gtest_filter=Autofill*:CreditCard*:FormField* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88243

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -15 lines)			Patch
M	chrome/browser/autofill/autofill_scanner.h	View	1 chunk	+12 lines, -6 lines	0 comments	Download
M	chrome/browser/autofill/autofill_scanner.cc	View	2 chunks	+14 lines, -5 lines	0 comments	Download
M	chrome/browser/autofill/credit_card_field.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autofill/phone_field.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages