Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: chrome/renderer/external_extension.cc

Issue 7115006: Added a check for the utf8 string input being empty (NULL). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/external_extension_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/external_extension.cc
diff --git a/chrome/renderer/external_extension.cc b/chrome/renderer/external_extension.cc
index f10133315a671450a5e2030e54601d0457433518..26c779bf0134609670feb9f368bfc361794b0be8 100644
--- a/chrome/renderer/external_extension.cc
+++ b/chrome/renderer/external_extension.cc
@@ -143,10 +143,10 @@ v8::Handle<v8::Value> ExternalExtensionWrapper::AddSearchProvider(
v8::Handle<v8::Value> ExternalExtensionWrapper::IsSearchProviderInstalled(
const v8::Arguments& args) {
if (!args.Length()) return v8::Undefined();
+ v8::String::Utf8Value utf8name(args[0]);
+ if (!utf8name.length()) return v8::Undefined();
- std::string name = std::string(*v8::String::Utf8Value(args[0]));
- if (!name.length()) return v8::Undefined();
-
+ std::string name = std::string(*utf8name);
RenderView* render_view = GetRenderView();
if (!render_view) return v8::Undefined();
« no previous file with comments | « no previous file | chrome/renderer/external_extension_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698