Issue 7115006: Added a check for the utf8 string input being empty (NULL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7115006: Added a check for the utf8 string input being empty (NULL). (Closed)

Created:
9 years, 6 months ago by levin

Modified:
9 years, 6 months ago

Reviewers:
commit-bot: I haz the power, Dmitry Titov

CC:
chromium-reviews, cbentzel+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Added a check for the utf8 string input being empty (NULL). Minor style and typo clean-ups. Also, a minor change to the test to close a page after it is done to clean up state associated with it. BUG=76162 TEST=SearchProviderTest.TestIsSearchProviderInstalledWithException Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88577

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -9 lines)			Patch
M	chrome/renderer/external_extension.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/renderer/external_extension_uitest.cc	View	1 2 3	5 chunks	+19 lines, -4 lines	0 comments	Download
M	chrome/test/data/is_search_provider_installed.html	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
A	chrome/test/data/is_search_provider_installed_with_exception.html	View	1 2	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 88577

Expand Messages | Collapse Messages

Issue 7115006: Added a check for the utf8 string input being empty (NULL). (Closed)

Description

Patch Set 1 #

Patch Set 2 : real patch #

Patch Set 3 : v2 #

Patch Set 4 : Fix typo. #

Messages