Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: views/controls/menu/menu_item_view.h

Issue 7115005: Reverse menu anchor position provided to views::MenuItemView for RTL languages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed BrowserActionOverflowMenuController. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/menu/menu_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/menu/menu_item_view.h
diff --git a/views/controls/menu/menu_item_view.h b/views/controls/menu/menu_item_view.h
index 8d293dca2637222eace74946d25d7e6b7a78a969..f24dadd48842e269c7d9c58369516a0439a0cf11 100644
--- a/views/controls/menu/menu_item_view.h
+++ b/views/controls/menu/menu_item_view.h
@@ -90,7 +90,8 @@ class MenuItemView : public View {
EMPTY
};
- // Where the menu should be anchored to.
+ // Where the menu should be anchored to for non-RTL languages. The
+ // opposite position will be used if base::i18n:IsRTL() is true.
enum AnchorPosition {
TOPLEFT,
TOPRIGHT
@@ -122,7 +123,8 @@ class MenuItemView : public View {
// Run methods. See description above class for details. Both Run methods take
// a rectangle, which is used to position the menu. |has_mnemonics| indicates
// whether the items have mnemonics. Mnemonics are identified by way of the
- // character following the '&'.
+ // character following the '&'. The anchor position is specified for non-RTL
+ // languages; the opposite value will be used for RTL.
void RunMenuAt(gfx::NativeWindow parent,
MenuButton* button,
const gfx::Rect& bounds,
« no previous file with comments | « views/controls/menu/menu_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698