Add support for hydrogen control instructions with >2 successor blocks.

Add support for hydrogen control instructions with >2 successor blocks.

This change makes the number of successors of a control instruction
configurable with a template parameter and changes the existing instructions
to use it.

To iterate over all successors I added an iterator instead of always calling
First- and SecondSuccessor.
Committed: http://code.google.com/p/v8/source/detail?r=8262

[fschneider, 2011-06-07 12:57:18]

This is a follow-up to http://codereview.chromium.org/7008011/

I addressed you comments there, but accidentally created a new issue on
Rietveld.

[Kevin Millikin (Chromium), 2011-06-10 11:39:15]

LGTM if you change the iterator interface slightly.

http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:802: bool HasNext() { return next_ <
instr_->SuccessorCount(); }
Most of the existing hydrogen/lithium iterators have changed to have the
interface 

bool Done();
T* Current();
void Advance();

Could you change this one?

http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:854: class HDeoptimize : public HControlInstruction
{
The rest of this file, with only a coupld of exceptions, doesn't have a space
before ':'

[fschneider, 2011-06-10 12:09:36]

http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:802: bool HasNext() { return next_ <
instr_->SuccessorCount(); }
On 2011/06/10 11:39:15, Kevin Millikin wrote:
> Most of the existing hydrogen/lithium iterators have changed to have the
> interface 
> 
> bool Done();
> T* Current();
> void Advance();
> 
> Could you change this one?

Done.

http://codereview.chromium.org/7114004/diff/6002/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:854: class HDeoptimize : public HControlInstruction
{
On 2011/06/10 11:39:15, Kevin Millikin wrote:
> The rest of this file, with only a coupld of exceptions, doesn't have a space
> before ':'

Done.