Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: net/socket/ssl_client_socket_pool.cc

Issue 7113008: Add revocation checking field trial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_client_socket_nss.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket_pool.cc
diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc
index 33c7e8b56ca1959858c153a87ebfd71c6d826fa5..565e0647cdf3e3e6880daf77c25d0b70e65175dc 100644
--- a/net/socket/ssl_client_socket_pool.cc
+++ b/net/socket/ssl_client_socket_pool.cc
@@ -329,19 +329,38 @@ int SSLConnectJob::DoSSLConnectComplete(int result) {
base::TimeDelta::FromMilliseconds(1),
base::TimeDelta::FromMinutes(10),
100);
- } else {
- UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency",
+ }
+
+ UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency",
+ connect_duration,
+ base::TimeDelta::FromMilliseconds(1),
+ base::TimeDelta::FromMinutes(10),
+ 100);
+
+ const std::string& host = params_->host_and_port().host();
+ bool is_google = host == "google.com" ||
+ (host.size() > 11 &&
+ host.rfind(".google.com") == host.size() - 11);
+ if (is_google) {
+ UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google",
connect_duration,
base::TimeDelta::FromMilliseconds(1),
base::TimeDelta::FromMinutes(10),
100);
- const std::string& host = params_->host_and_port().host();
- bool is_google = host == "google.com" ||
- (host.size() > 11 &&
- host.rfind(".google.com") == host.size() - 11);
- if (is_google) {
- UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google",
+ base::FieldTrial* trial = base::FieldTrialList::Find("RevCheckingImpact");
+ if (trial) {
+ std::string histogram_name;
+ if (trial->group() != base::FieldTrial::kDefaultGroupNumber ||
+ !params_->ssl_config().rev_checking_enabled) {
+ histogram_name =
+ "Net.SSL_Connection_Latency_Google_No_Revocation_Checking";
+ } else {
+ histogram_name =
+ "Net.SSL_Connection_Latency_Google_Revocation_Checking";
+ }
+
+ UMA_HISTOGRAM_CUSTOM_TIMES(histogram_name,
connect_duration,
base::TimeDelta::FromMilliseconds(1),
base::TimeDelta::FromMinutes(10),
« no previous file with comments | « net/socket/ssl_client_socket_nss.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698