Add revocation checking field trial.

net/socket/ssl_client_socket_pool.cc

Index: net/socket/ssl_client_socket_pool.cc
diff --git a/net/socket/ssl_client_socket_pool.cc b/net/socket/ssl_client_socket_pool.cc
index 33c7e8b56ca1959858c153a87ebfd71c6d826fa5..b01aadbe6e647b52415dbc36ae49f9654e8191fa 100644
--- a/net/socket/ssl_client_socket_pool.cc
+++ b/net/socket/ssl_client_socket_pool.cc
@@ -329,24 +329,36 @@ int SSLConnectJob::DoSSLConnectComplete(int result) {
                                  base::TimeDelta::FromMilliseconds(1),
                                  base::TimeDelta::FromMinutes(10),
                                  100);
-    } else {
-      UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency",
+    }
+
+    UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency",

[Mike Belshe, 2011/06/08 04:50:38]

note:  you're changing the definition of these histograms... Before they were
"!spdy", but now they are everything - spdy or not.  I think this is ok....

[agl, 2011/06/08 18:57:12]

Yes, that's was intentional.

+                               connect_duration,
+                               base::TimeDelta::FromMilliseconds(1),
+                               base::TimeDelta::FromMinutes(10),
+                               100);
+
+    const std::string& host = params_->host_and_port().host();
+    bool is_google = host == "google.com" ||
+                     (host.size() > 11 &&
+                      host.rfind(".google.com") == host.size() - 11);
+    if (is_google) {
+      UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google",
                                  connect_duration,
                                  base::TimeDelta::FromMilliseconds(1),
                                  base::TimeDelta::FromMinutes(10),
                                  100);
+    }
 
-      const std::string& host = params_->host_and_port().host();
-      bool is_google = host == "google.com" ||
-                       (host.size() > 11 &&
-                        host.rfind(".google.com") == host.size() - 11);
-      if (is_google) {
-        UMA_HISTOGRAM_CUSTOM_TIMES("Net.SSL_Connection_Latency_Google",
-                                   connect_duration,
-                                   base::TimeDelta::FromMilliseconds(1),
-                                   base::TimeDelta::FromMinutes(10),
-                                   100);
-      }
+    static const bool rev_checking_trial =
+        base::FieldTrialList::TrialExists("RevCheckingImpact");
+    if (rev_checking_trial) {

[Mike Belshe, 2011/06/08 04:50:38]

I think this is a problem.

You will compare:
a) sites which could have been pinned but which we overrode.
to 
b) all other sites that could have been pinned or not

[agl, 2011/06/08 18:57:12]

Yes, I meant to put the histogram in the |is_google| condition. However, another
case occurred: a user could be outside the trail but have manually disabled
revocation checking. Please see the code now that I've addressed that and check
that my assumptions about field trials are correct.

+      UMA_HISTOGRAM_CUSTOM_TIMES(base::FieldTrial::MakeName(
+                                     "Net.SSL_Connection_Latency_Google",
+                                     "RevCheckingImpact"),
+                                 connect_duration,
+                                 base::TimeDelta::FromMilliseconds(1),
+                                 base::TimeDelta::FromMinutes(10),
+                                 100);
     }
   }