Add revocation checking field trial.

chrome/browser/browser_main.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_main.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 484 matching lines @@
                 30));
     const int connect_backup_jobs_enabled = trial->kDefaultGroupNumber;
     trial->AppendGroup("ConnectBackupJobsDisabled",
                        kConnectBackupJobsProbability);
     const int trial_group = trial->group();
     net::internal::ClientSocketPoolBaseHelper::set_connect_backup_jobs_enabled(
         trial_group == connect_backup_jobs_enabled);
   }
 }
 
+void BrowserMainParts::RevocationCheckingDisabledFieldTrial() {
+  const base::FieldTrial::Probability kDivisor = 100;
+  base::FieldTrial::Probability probability = 50;  // 50/50 trial
+
+  // After August 30, 2011 builds, it will always be in default group.
+  scoped_refptr<base::FieldTrial> trial(
+      new base::FieldTrial(
+          "RevCheckingImpact", kDivisor, "RevChecking_control", 2011, 8, 30));

[Mike Belshe, 2011/06/08 04:50:38]

nit:  change "RevChecking_control" to "_control"?

I hope this will only be for pinned sites too, right?  Otherwise, this isn't a
strict A/B test.

[agl, 2011/06/08 18:57:12]

Have changed to "control" since none of the other users of FieldTrial in this
file prepend underscores. Please let me know if there's something that I missed.

+
+  int disabled_group = trial->AppendGroup(
+      "RevChecking_disabled_for_pinned_sites", probability);

[Mike Belshe, 2011/06/08 04:50:38]

nit:  change to "_disabled"

[agl, 2011/06/08 18:57:12]

Done (with the same remark about the leading underscore).

+
+  int trial_grp = trial->group();
+  if (trial_grp == disabled_group)
+    net::SSLConfigService::DisableRevCheckingForPinnedSites();
+}
+
 // BrowserMainParts: |MainMessageLoopStart()| and related ----------------------
 
 void BrowserMainParts::MainMessageLoopStart() {
   PreMainMessageLoopStart();
 
   main_message_loop_.reset(new MessageLoop(MessageLoop::TYPE_UI));
 
   // TODO(viettrungluu): should these really go before setting the thread name?
   system_monitor_.reset(new base::SystemMonitor);
   hi_res_timer_manager_.reset(new HighResolutionTimerManager);
@@ skipping 70 matching lines @@
     chrome_browser_net_websocket_experiment::WebSocketExperimentRunner::Start();
 
   // Note: make sure to call ConnectionFieldTrial() before
   // ProxyConnectionsFieldTrial().
   ConnectionFieldTrial();
   SocketTimeoutFieldTrial();
   ProxyConnectionsFieldTrial();
   prerender::ConfigurePrefetchAndPrerender(parsed_command_line());
   SpdyFieldTrial();
   ConnectBackupJobsFieldTrial();
+  RevocationCheckingDisabledFieldTrial();
 }
 
 // -----------------------------------------------------------------------------
 // TODO(viettrungluu): move more/rest of BrowserMain() into above structure
 
 namespace {
 
 // This function provides some ways to test crash and assertion handling
 // behavior of the program.
 void HandleTestParameters(const CommandLine& command_line) {
@@ skipping 1363 matching lines @@
 #if defined(OS_CHROMEOS)
   // To be precise, logout (browser shutdown) is not yet done, but the
   // remaining work is negligible, hence we say LogoutDone here.
   chromeos::BootTimesLoader::Get()->AddLogoutTimeMarker("LogoutDone",
                                                         false);
   chromeos::BootTimesLoader::Get()->WriteLogoutTimes();
 #endif
   TRACE_EVENT_END_ETW("BrowserMain", 0, 0);
   return result_code;
 }