Revert 87919 - Revert 87905 (broke PPAPITest.Scrollbar on win) - PPAPI: Fix interface functions t...

Revert 87919 - Revert 87905 (broke PPAPITest.Scrollbar on win) - PPAPI: Fix interface functions that take PP_CompletionCallbacks, but don't
return codes from pp_errors.h

Tests did not go green after the revert. The test is for a different PPAPI interface (PPB_Scrollbar_Dev), so the change is unrelated.

87905 - Review URL: http://codereview.chromium.org/6975053
87919 - Review URL: http://codereview.chromium.org/7058061

BUG=85010
TEST=none

TBR=dhollowa@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88055

[Nico, 2011-06-06 22:30:55]

LGTM

say "test didn't go green after the revert" somewhere in the CL description

On Mon, Jun 6, 2011 at 3:28 PM,  <polina@google.com> wrote:
> Reviewers: Nico,
>
> Description:
> Revert 87919 - Revert 87905 (broke PPAPITest.Scrollbar on win) - PPAPI: Fix
> interface functions that take PP_CompletionCallbacks, but don't
> return codes from pp_errors.h
>
> 87905 - Review URL: http://codereview.chromium.org/6975053
> 87919 - Review URL: http://codereview.chromium.org/7058061
>
> BUG=85010
> TEST=none
>
> Review URL: http://codereview.chromium.org/6975053
> Review URL: http://codereview.chromium.org/7058061
>
> TBR=dhollowa@chromium.org
>
> Please review this at http://codereview.chromium.org/7112040/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     ppapi/c/dev/ppb_layer_compositor_dev.h
>  M     ppapi/c/dev/ppb_video_decoder_dev.h
>  M     ppapi/cpp/dev/video_decoder_dev.h
>  M     ppapi/cpp/dev/video_decoder_dev.cc
>  M     ppapi/tests/arch_dependent_sizes_32.h
>  M     ppapi/tests/arch_dependent_sizes_64.h
>  M     ppapi/tests/test_video_decoder.h
>  M     ppapi/tests/test_video_decoder.cc
>  M     webkit/plugins/ppapi/ppb_layer_compositor_impl.h
>  M     webkit/plugins/ppapi/ppb_layer_compositor_impl.cc
>  M     webkit/plugins/ppapi/ppb_video_decoder_impl.h
>  M     webkit/plugins/ppapi/ppb_video_decoder_impl.cc
>
>
>

[polina, 2011-06-06 22:34:56]

On 2011/06/06 22:30:55, Nico wrote:
> LGTM
> 
> say "test didn't go green after the revert" somewhere in the CL description
> 
> On Mon, Jun 6, 2011 at 3:28 PM,  <mailto:polina@google.com> wrote:
> > Reviewers: Nico,
> >
> > Description:
> > Revert 87919 - Revert 87905 (broke PPAPITest.Scrollbar on win) - PPAPI: Fix
> > interface functions that take PP_CompletionCallbacks, but don't
> > return codes from pp_errors.h
> >
> > 87905 - Review URL: http://codereview.chromium.org/6975053
> > 87919 - Review URL: http://codereview.chromium.org/7058061
> >
> > BUG=85010
> > TEST=none
> >
> > Review URL: http://codereview.chromium.org/6975053
> > Review URL: http://codereview.chromium.org/7058061
> >
> > mailto:TBR=dhollowa@chromium.org
> >
> > Please review this at http://codereview.chromium.org/7112040/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src/
> >
> > Affected files:
> > &nbsp;M &nbsp; &nbsp; ppapi/c/dev/ppb_layer_compositor_dev.h
> > &nbsp;M &nbsp; &nbsp; ppapi/c/dev/ppb_video_decoder_dev.h
> > &nbsp;M &nbsp; &nbsp; ppapi/cpp/dev/video_decoder_dev.h
> > &nbsp;M &nbsp; &nbsp; ppapi/cpp/dev/video_decoder_dev.cc
> > &nbsp;M &nbsp; &nbsp; ppapi/tests/arch_dependent_sizes_32.h
> > &nbsp;M &nbsp; &nbsp; ppapi/tests/arch_dependent_sizes_64.h
> > &nbsp;M &nbsp; &nbsp; ppapi/tests/test_video_decoder.h
> > &nbsp;M &nbsp; &nbsp; ppapi/tests/test_video_decoder.cc
> > &nbsp;M &nbsp; &nbsp; webkit/plugins/ppapi/ppb_layer_compositor_impl.h
> > &nbsp;M &nbsp; &nbsp; webkit/plugins/ppapi/ppb_layer_compositor_impl.cc
> > &nbsp;M &nbsp; &nbsp; webkit/plugins/ppapi/ppb_video_decoder_impl.h
> > &nbsp;M &nbsp; &nbsp; webkit/plugins/ppapi/ppb_video_decoder_impl.cc
> >
> >
> >

done