Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 7112032: Re-land r8140: Deoptimize on never-executed code-paths. (Closed)

Created:
9 years, 6 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Re-land r8140: Deoptimize on never-executed code-paths. Original cl: http://codereview.chromium.org/7105015 I'm removing the test GlobalLoadICGC test that was introduced for testing inlined global cell loads (in the classic backend) and has an invalid assumption about the number of global objects referenced from a v8 context. We don't have this feature with Crankshaft anymore. Committed: http://code.google.com/p/v8/source/detail?r=8185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -97 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 8 chunks +79 lines, -45 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +15 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/type-info.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M test/mjsunit/regress/regress-1118.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 6 months ago (2011-06-06 14:36:22 UTC) #1
danno
9 years, 6 months ago (2011-06-06 14:54:02 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698