cld: Fix infinite recursion.

cld: Fix infinite recursion.

Putting stuff in the 'base' namespace is still dangerous,
but we don't violate ODR since its definition is identical
to Chrome's base::strcasecmp.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87818

[Nico, 2011-06-03 18:25:37]

It's still an ODR violation, so it's technically not more correct than it was
before, right? :-/

LGTM anyway

[Evan Martin, 2011-06-03 18:25:59]

On 2011/06/03 18:25:37, Nico wrote:
> It's still an ODR violation, so it's technically not more correct than it was
> before, right? :-/
> 
> LGTM anyway

[Evan Martin, 2011-06-03 18:26:21]

On 2011/06/03 18:25:59, Evan Martin wrote:
> On 2011/06/03 18:25:37, Nico wrote:
> > It's still an ODR violation, so it's technically not more correct than it
was
> > before, right? :-/

I wonder if the "inline" changes things?
I pointed my local ODR expert at this review, perhaps he'll have comments.

[Nico, 2011-06-03 23:49:29]

> I wonder if the "inline" changes things?
> I pointed my local ODR expert at this review, perhaps he'll have comments.

Did he?

[Evan Martin, 2011-06-06 22:33:20]

On Fri, Jun 3, 2011 at 4:49 PM,  <thakis@chromium.org> wrote:
>> I wonder if the "inline" changes things?
>> I pointed my local ODR expert at this review, perhaps he'll have comments.
>
> Did he?

He said as long as the function definitions are the same, we're safe.