Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 7112012: Disable strict mode for now until V8 bug 1423 is fixed. (Closed)

Created:
9 years, 6 months ago by Jamie
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Disable strict mode for now until V8 bug 1423 is fixed. BUG=http://code.google.com/p/v8/issues/detail?id=1423 TEST=Click the OAuth and email buttons on a 64-bit Linux machine. Chrome should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M remoting/webapp/me2mom/remoting.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jamie
A minuscule code review for you.
9 years, 6 months ago (2011-06-03 17:53:08 UTC) #1
dmaclach1
LGTM On Fri, Jun 3, 2011 at 10:53, <jamiewalch@chromium.org> wrote: > Reviewers: dmac, > > ...
9 years, 6 months ago (2011-06-03 18:26:34 UTC) #2
commit-bot: I haz the power
9 years, 6 months ago (2011-06-04 08:04:24 UTC) #3
Change committed as 87920

Powered by Google App Engine
This is Rietveld 408576698