Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4599)

Unified Diff: chrome/browser/download/download_util.cc

Issue 7112011: Change DownloadProcessHandle to be more of an encapsulated class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Get rid of cancel code in download_util. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_util.cc
diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc
index ee2fe3a5aa5246dcc38127cb1393afa9f999204b..48094c8b0cbd279b57a693fcd4f23e9bc7675af2 100644
--- a/chrome/browser/download/download_util.cc
+++ b/chrome/browser/download/download_util.cc
@@ -833,26 +833,6 @@ void DownloadUrl(
*context);
}
-static void CancelDownloadRequestOnIOThread(
- ResourceDispatcherHost* rdh, DownloadProcessHandle process_handle) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- // |rdh| may be NULL in unit tests.
- if (!rdh)
- return;
-
- rdh->CancelRequest(process_handle.child_id(),
- process_handle.request_id(),
- false);
-}
-
-void CancelDownloadRequest(ResourceDispatcherHost* rdh,
- DownloadProcessHandle process_handle) {
- BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- NewRunnableFunction(&download_util::CancelDownloadRequestOnIOThread,
- rdh, process_handle));
-}
-
void NotifyDownloadInitiated(int render_process_id, int render_view_id) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
RenderViewHost* rvh = RenderViewHost::FromID(render_process_id,

Powered by Google App Engine
This is Rietveld 408576698