Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/download/download_file.cc

Issue 7112011: Change DownloadProcessHandle to be more of an encapsulated class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Get rid of cancel code in download_util. Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_file.cc
diff --git a/chrome/browser/download/download_file.cc b/chrome/browser/download/download_file.cc
index d1a3470c00a3d38c75b8fbb7426aff053693cb76..5860ee47380c03e625dd28bd6e9516635cea84fa 100644
--- a/chrome/browser/download/download_file.cc
+++ b/chrome/browser/download/download_file.cc
@@ -30,9 +30,8 @@ DownloadFile::~DownloadFile() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
}
-void DownloadFile::CancelDownloadRequest(ResourceDispatcherHost* rdh) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
- download_util::CancelDownloadRequest(rdh, process_handle_);
+void DownloadFile::CancelDownloadRequest() {
Paweł Hajdan Jr. 2011/06/04 08:58:51 nit: Please add DCHECK(BrowserThread::CurrentlyOn(
Randy Smith (Not in Mondays) 2011/06/07 22:41:11 Done.
+ process_handle_.CancelRequest();
}
DownloadManager* DownloadFile::GetDownloadManager() {
@@ -43,14 +42,10 @@ DownloadManager* DownloadFile::GetDownloadManager() {
std::string DownloadFile::DebugString() const {
return base::StringPrintf("{"
" id_ = " "%d"
- " child_id = " "%d"
- " request_id = " "%d"
- " render_view_id = " "%d"
+ " process_handle = %s"
" Base File = %s"
" }",
id_,
- process_handle_.child_id(),
- process_handle_.request_id(),
- process_handle_.render_view_id(),
+ process_handle_.DebugString().c_str(),
BaseFile::DebugString().c_str());
}

Powered by Google App Engine
This is Rietveld 408576698